Subject: kern/33395: Mistook name for macro OCW2_*.
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <kiyohara@kk.iij4u.or.jp>
List: netbsd-bugs
Date: 04/30/2006 17:35:00
>Number:         33395
>Category:       kern
>Synopsis:       Mistook name for macro OCW2_*.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 30 17:35:00 +0000 2006
>Originator:     KIYOHARA Takashi
>Release:        NetBSD/i386 3.99.18
>Organization:
>Environment:
NetBSD highpriestess.fool 3.99.18 NetBSD 3.99.18 (HIGHPRIESTESS) #0: Mon May  1 02:09:14 JST 2006  lance@highpriestess.fool:/sys/arch/i386/compile/HIGHPRIESTESS i386

>Description:
Mistook name for macro OCW2_{EOI,SL,R}. Its defined OCW3_{EOI,SL,R} now. See datasheet.
Please fix.
>How-To-Repeat:

>Fix:
Index: sys/dev/ic/i8259reg.h
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/i8259reg.h,v
retrieving revision 1.2
diff -u -r1.2 i8259reg.h
--- sys/dev/ic/i8259reg.h       21 Jun 2001 18:57:04 -0000      1.2
+++ sys/dev/ic/i8259reg.h       30 Apr 2006 16:34:25 -0000
@@ -83,9 +83,9 @@
 
 #define        PIC_OCW2        0x00    /* Operational Control Word 2 (w) */
 #define        OCW2_SELECT     (0)             /* select OCW2 */
-#define        OCW3_EOI        (1U << 5)       /* EOI */
-#define        OCW3_SL         (1U << 6)       /* specific */
-#define        OCW3_R          (1U << 7)       /* rotate */
+#define        OCW2_EOI        (1U << 5)       /* EOI */
+#define        OCW2_SL         (1U << 6)       /* specific */
+#define        OCW2_R          (1U << 7)       /* rotate */
 #define        OCW2_ILS(x)     ((x) << 0)      /* interrupt level select */
 
 #define        PIC_OCW3        0x00    /* Operational Control Word 3 (r/w) */