Subject: toolchain/33219: build failure with MKUUCP=no (patch included)
To: None <toolchain-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <j+nbsd@2006.salmi.ch>
List: netbsd-bugs
Date: 04/08/2006 15:10:01
>Number:         33219
>Category:       toolchain
>Synopsis:       build failure with MKUUCP=no (patch included)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 08 15:10:00 +0000 2006
>Originator:     Jukka Salmi
>Release:        NetBSD 3.99.17
>Environment:
System: NetBSD moray.salmi.ch 3.99.17 NetBSD 3.99.17 (GENERIC.APM) #0: Sat Apr 8 05:17:45 CEST 2006 build@moray.salmi.ch:/build/nbsd/i386/sys/arch/i386/compile/GENERIC.APM i386
Architecture: i386
Machine: i386
>Description:
Building e.g. a distribution with MKUUCP=no fails because
${DESTDIR}/usr/bin/cu is installed although it shouldn't be.
>How-To-Repeat:
Set MKUUCP=no in /etc/mk.conf, and either build a distribution and see
it fail with a flist/DESTDIR mismatch for usr/bin/cu, or do the
following:

$ cd src/usr.bin/tip
$ make -V MKUUCP
no
$ make -V LINKS
${BINDIR}/tip ${BINDIR}/cu

The last command should print an empty line...

>Fix:
bsd.own.mk needs to be included before testing for MKUUCP:

Index: usr.bin/tip/Makefile
===================================================================
RCS file: /cvsroot/src/usr.bin/tip/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- usr.bin/tip/Makefile	5 Apr 2006 13:04:33 -0000	1.25
+++ usr.bin/tip/Makefile	8 Apr 2006 14:53:32 -0000
@@ -25,6 +25,8 @@
 #	BUFSIZ			buffer sizing from stdio, must be fed
 #				explicitly to remcap.c if not 1024
 
+.include <bsd.own.mk>
+
 WARNS=4
 PROG=	tip
 .if !defined(MKUUCP) || ${MKUUCP} != no