Subject: Re: kern/32928: bpf filter can fail to extract a 32-bit quantity
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Pavel Cahyna <pcah8322@artax.karlin.mff.cuni.cz>
List: netbsd-bugs
Date: 02/25/2006 14:35:02
The following reply was made to PR kern/32928; it has been noted by GNATS.

From: Pavel Cahyna <pcah8322@artax.karlin.mff.cuni.cz>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: kern/32928: bpf filter can fail to extract a 32-bit quantity
Date: Sat, 25 Feb 2006 15:32:07 +0100

 >  >  +	} else {
 >  >  +		return (m_xhalf(m, k, err) << 16) | m_xhalf(m, k+2, err);
 >  
 >  I suspect you really don't want to be doing that unless the data
 >  actually crosses 2 mbuf boundaries.
 
 Why not? Because of performance, or is such code incorrect?
 
 Pavel Cahyna