Subject: Re: kern/32644: gsip(4) sends byte-swapped vlan tags
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Jason Thorpe <thorpej@shagadelic.org>
List: netbsd-bugs
Date: 01/27/2006 03:35:03
The following reply was made to PR kern/32644; it has been noted by GNATS.
From: Jason Thorpe <thorpej@shagadelic.org>
To: christos@zoulas.com (Christos Zoulas)
Cc: gnats-bugs@netbsd.org, kern-bug-people@netbsd.org,
gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/32644: gsip(4) sends byte-swapped vlan tags
Date: Thu, 26 Jan 2006 19:33:30 -0800
On Jan 26, 2006, at 7:30 PM, Christos Zoulas wrote:
> This does not seem right because in the first part of the patch you
> do:
>
> + htole32(EXTSTS_VPKT |
> + (bswap16(VLAN_TAG_VALUE(mtag)) &
> + EXTSTS_VTCI));
>
> and in the second:
>
> | + VLAN_INPUT_TAG(ifp, m, bswap16(extsts & EXTSTS_VTCI),
>
> because in the first patch you are not bswapping16 EXTSTS_VTCI and
> in the
> second you do?
Why does this seem wrong to you?
-- thorpej