Subject: Re: kern/32644: gsip(4) sends byte-swapped vlan tags
To: Christos Zoulas <email@example.com>
From: Jason Thorpe <firstname.lastname@example.org>
Date: 01/26/2006 19:33:30
On Jan 26, 2006, at 7:30 PM, Christos Zoulas wrote:
> This does not seem right because in the first part of the patch you
> + htole32(EXTSTS_VPKT |
> + (bswap16(VLAN_TAG_VALUE(mtag)) &
> + EXTSTS_VTCI));
> and in the second:
> | + VLAN_INPUT_TAG(ifp, m, bswap16(extsts & EXTSTS_VTCI),
> because in the first patch you are not bswapping16 EXTSTS_VTCI and
> in the
> second you do?
Why does this seem wrong to you?