Subject: Re: port-mac68k/32583: mac68k netbsd-2 panics during rcp(1)
To: None <email@example.com,>
From: Dave Huang <firstname.lastname@example.org>
Date: 01/25/2006 15:46:26
On Wed, Jan 25, 2006 at 09:25:02PM +0000, Hauke Fath wrote:
> Meaning you'd want
> if (!(c)) panic(...)
> instead above?
Yes, or to conform to the NetBSD style guide,
if ((c) == 0) panic(...)
However, that doesn't fix the actual bug; it just fixes the DIAGNOSTIC
check so that it'll panic with a useful message instead of getting a
bus error trap.
The actual fix is in the patch to sys/arch/mac68k/dev/if_ae.c that I
sent back on Jan 20: