Subject: Re: kern/31323: vge on !i386 is broken.
To: None <gnats-bugs@netbsd.org>
From: Murata Shuuichirou <mrt@notwork.org>
List: netbsd-bugs
Date: 09/16/2005 15:30:54
In message <20050915212235.GD11694@drowsy.duskware.de>,
 `martin@duskware.de' wrote:
> On Thu, Sep 15, 2005 at 06:39:00PM +0000, mrt@notwork.org wrote:
>> Although I'm not sure that following patch is correct fix, I can use vge on
>> amd64 with the patch:
>
> I think your patch is correct, but the whole EHTER_ALIGN definition should
> be removed from if_vgevar.h too.

Yes, IF my patch is correct, ETHER_ALIGN should also be removed.  But, I
don't know:

  1. What is ETHER_ALIGN, and why ETHER_ALIGN is used here.
  2. Whether amd64 needs whole VGE_FIXUP_RX or not.

So, I can't say "my patch is correct", yet.  I'll test vge without
VGE_FIXUP_RX against amd64 machine, later today.

(Even if amd64 doesn't need VGE_FIXUP_RX, other architectures still need
VGE_FIXUP_RX. So, VGE_FIXUP_RX itself should remain.)
-- 
MURATA Shuuichirou