Subject: Re: kern/31304: sk and rtk don't contribute to random pool [patch included]
To: Rhialto <email@example.com>
From: Rui Paulo <rpaulo@NetBSD.org>
Date: 09/13/2005 14:23:47
Content-Type: text/plain; charset=us-ascii
On 2005.09.13 14:39:48 +0200, Rhialto wrote:
| Rui Paulo wrote:
| > I think the patch looks good, but you should prefix variables in the
| > 'sc' struct with 'sc' as it's already done, i.e. sc_rnd_source.
| I can do that of course. It just was this way because in other
| interfaces it was that way.
Hmm. I looked at tlp(4) and it had the 'sc' prefix.
| Note that in one of the diffs, one such prefix is edited because in the
| incomplete existing code, it must have been pasted in a similar way.
| On Mon 12 Sep 2005 at 22:05:16 +0100, Rui Paulo wrote:
| > BTW, are you aware that we currently don't collect random data from
| > network interfaces ?
| By default, yes. But I usually turn it on when I remember it - on my
| externally reachable server I get enough portscans and other incoming
| traffic from many different sources that it seems useful.
Well, like I've been told, it has the major problem of someone
controling entropy externally, but that has nothing to do with your patch.
-- Rui Paulo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (NetBSD)
-----END PGP SIGNATURE-----