Subject: Re: misc/30738
To: None <email@example.com>
From: Giorgos Keramidas <firstname.lastname@example.org>
Date: 07/13/2005 17:44:03
On 2005-07-13 14:37, email@example.com wrote:
> Synopsis: minor sys/queue.h syntax nit in SIMPLEQ_* comment
> State-Changed-From-To: open->feedback
> State-Changed-By: firstname.lastname@example.org
> State-Changed-When: Wed, 13 Jul 2005 14:37:03 +0000
> You changed one sentence to:
> "New elements can be added to the list before or after an existing element"
> however the header file only contains a SIMPLEQ_INSERT_AFTER macro,
> no SIMPLEQ_INSERT_BEFORE macro.
> Additionally, the existence of the SIMPLEQ_REMOVE macro makes the first part
> of the diff sound wrong too.
Sorry, I wasn't clear enough. In the HEAD version of queue.h, near
lines 58-63 I can read (even now, through the Web interface of the CVS
# 1.11 mycroft 58: * A simple queue is headed by a pair of pointers, one the head of the
# 59: * list and the other to the tail of the list. The elements are singly
# 60: * linked to save space, so only elements can only be removed from the
# 1.18 tv 61: * head of the list. New elements can be added to the list after
# 1.11 mycroft 62: * an existing element, at the head of the list, or at the end of the
# 1.16 nathanw 63: * list. A simple queue may only be traversed in the forward direction.
There are two "only" instances in line 60. The first one can go IMHO.