Subject: Re: port-i386/30643: ACPI in 3.99.7 does not route all
To: None <port-i386-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: Ed Gould <ed@left.wing.org>
List: netbsd-bugs
Date: 06/30/2005 18:25:01
The following reply was made to PR port-i386/30643; it has been noted by GNATS.
From: Ed Gould <ed@left.wing.org>
To: gnats-bugs@netbsd.org
Cc: port-i386-maintainer@netbsd.org, gnats-admin@netbsd.org
Subject: Re: port-i386/30643: ACPI in 3.99.7 does not route all
interrupts
Date: Thu, 30 Jun 2005 11:24:46 -0700
>> Fix:
> none supplied
>
Recent changes to dev/acpi/acpi.c were incorrect. Note that the "line"
variable is of type "uint". This patch fixes the problem.
> cvs diff dev/acpi/acpi.c
Index: dev/acpi/acpi.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi.c,v
retrieving revision 1.74
diff -u -r1.74 acpi.c
--- dev/acpi/acpi.c 21 Jun 2005 11:49:10 -0000 1.74
+++ dev/acpi/acpi.c 30 Jun 2005 18:20:04 -0000
@@ -1227,7 +1227,7 @@
if (ACPI_FAILURE(rv))
continue;
line = acpi_get_intr(link);
- if (line < 1) {
+ if ((line == -1) || (line == 0)) {
printf("%s: fixing up intr link %s\n",
sc->sc_dev.dv_xname, PrtElement->Source);
rv = acpi_allocate_resources(link);