Subject: bin/30432: rcorder doesn't perform enough sanity checking
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org>
From: None <lukem@NetBSD.org>
List: netbsd-bugs
Date: 06/05/2005 06:42:00
>Number:         30432
>Category:       bin
>Synopsis:       rcorder doesn't perform enough sanity checking
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 05 06:42:00 +0000 2005
>Originator:     Luke Mewburn
>Release:        NetBSD 3.0_BETA
>Organization:
TNF
>Environment:
Architecture: i386
Machine: i386
>Description:
	rcorder(8) doesn't provide enough sanity checking;
	when you provide the same file multiple times on
	the command line it just gets added to the internal
	"list of filenames" and other data structures.

>How-To-Repeat:
	Code inspection.
	I'm sure a test case can be easily consed up to prove this.

>Fix:
	Detect if a file is being added again and provide
	a mechanism to override the previous entry, taking
	into account the other data structures that already
	refer to the previous node.