Subject: misc/30049: missing CLEANFILES entries in gnu/lib/libgcc3/Makefile.inc
To: None <misc-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <hira@po6.nsk.ne.jp>
List: netbsd-bugs
Date: 04/24/2005 12:19:00
>Number:         30049
>Category:       misc
>Synopsis:       missing CLEANFILES entries in gnu/lib/libgcc3/Makefile.inc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 24 12:19:00 +0000 2005
>Originator:     Kouichirou Hiratsuka
>Release:        NetBSD 3.99.3
>Organization:
>Environment:
System: NetBSD firefly.localdomain 3.99.3 NetBSD 3.99.3 (PBG4.current) #4: Sun Apr 24 14:55:54 JST 2005 root@firefly.localdomain:/work/NetBSD/src/sys/arch/macppc/compile/PBG4.current macppc
Architecture: powerpc
Machine: macppc
>Description:
	After `make cleandir', the files which are defined with
	G_LIB2ADD are left under gnu/lib/libgcc3.

# cd /usr/src/gnu/lib/libgcc3
# ls libgcc*/*.S
ls: libgcc*/*.S: No such file or directory
# make
[snip]
# make cleandir
[snip]
# ls libgcc*/*.S
libgcc/tramp.S      libgcc_s/tramp.S
#

>How-To-Repeat:
	see above

>Fix:
	Add G_LIB2ADD to CLEANFILES.

Index: gnu/lib/libgcc3/Makefile.inc
===================================================================
RCS file: /cvs/cvsroot/src/gnu/lib/libgcc3/Makefile.inc,v
retrieving revision 1.7
diff -u -r1.7 Makefile.inc
--- gnu/lib/libgcc3/Makefile.inc	29 Mar 2004 09:32:49 -0000	1.7
+++ gnu/lib/libgcc3/Makefile.inc	24 Apr 2005 10:49:33 -0000
@@ -22,6 +22,9 @@
 .if !empty(G_LIB1ASMFUNCS)
 LIB1ASMFUNCS=	${G_LIB1ASMFUNCS:=.S}
 .endif
+.if !empty(G_LIB2ADD)
+LIB2ADD=	${G_LIB2ADD:M${GNUHOSTDIST}/*:T:S/.asm/.S/}
+.endif
 
 DPSRCS+=	${.CURDIR}/../arch/${MACHINE_ARCH}.mk tconfig.h
 CLEANFILES+=	${LIB2FUNCS} ${LIB2FUNCS_ST} ${LIB2DIVMOD} cs-tconfig.h \
@@ -29,6 +32,9 @@
 .if !empty(G_LIB1ASMFUNCS)
 CLEANFILES+=	${LIB1ASMFUNCS}
 .endif
+.if !empty(G_LIB2ADD)
+CLEANFILES+=	${LIB2ADD}
+.endif
 
 # XXX
 .if ${MACHINE_ARCH} == "m68000"
@@ -65,7 +71,8 @@
 	printf '#define L${.PREFIX}\n#include <${G_LIB1ASMSRC}>\n' >${.TARGET}
 .endif
 
-${G_LIB2ADD:M${GNUHOSTDIST}/*:T:S/.asm/.S/}: ${.CURDIR}/Makefile ${G_LIB2ADD}
+.if !empty(G_LIB2ADD)
+${LIB2ADD}: ${.CURDIR}/Makefile ${G_LIB2ADD}
 	@echo copying ${G_LIB2ADD}
 	for i in ${G_LIB2ADD}; do \
 		j=$${i##*/}; \
@@ -73,6 +80,7 @@
 		cp $$i $$j; \
 	done
 	@echo copying ${G_LIB2ADD} complete
+.endif
 
 ${LIB2_EH:.c=.o}:
 	${_MKTARGET_COMPILE}