Subject: Re: xsrc/29401: Makefiles warnings while compiling X from xsrc
To: None <gnats-bugs@NetBSD.org>
From: Nicolas Joly <firstname.lastname@example.org>
Date: 02/17/2005 11:24:38
On Thu, Feb 17, 2005 at 09:05:02AM +0000, Izumi Tsutsui wrote:
> The following reply was made to PR xsrc/29401; it has been noted by GNATS.
> From: Izumi Tsutsui <email@example.com>
> To: firstname.lastname@example.org
> Cc: email@example.com, firstname.lastname@example.org,
> Subject: Re: xsrc/29401: Makefiles warnings while compiling X from xsrc
> Date: Thu, 17 Feb 2005 18:04:40 +0900
> > >Synopsis: Makefiles warnings while compiling X from xsrc
> > >Description:
> > I'm getting many warnings during xsrc Makefiles generation on amd64 :
> Hmm, I'd like to move the definition of -D__AMD64__ in NetBSDMachineDefines
> from MACHINE dependent part to MACHINE_CPU part because:
> - __AMD64__ is also used in some libraries (not only by Xserver)
> - share/mk/bsd.x11.mk implicitly add -D__AMD64__ if MACHINE_ARCH == x86_64
> - currently amd64 is the only MACHINE which have x86_64 MACHINE_CPU anyway
> (though the real fix is to add "defined(__x86_64__)" where appropriate, IMO)
> Would you please confirm if the attached version properly works?
Works fine. Thanks.
Biological Software and Databanks.
Institut Pasteur, Paris.