Subject: kern/29245: Fix to make audio work on Alpha PWS
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Rhialto <rhialto@azenomei.knuffel.net>
List: netbsd-bugs
Date: 02/05/2005 14:05:01
>Number:         29245
>Category:       kern
>Synopsis:       Fix to make audio work on Alpha PWS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 05 14:05:01 +0000 2005
>Originator:     Rhialto
>Release:        NetBSD 2.0
>Organization:
	
>Environment:
System: NetBSD azenomei.falu.nl 2.0 NetBSD 2.0 (AZENOMEI2.0) #1: Tue Jan 11 00:02:19 CET 2005 rhialto@azenomei.falu.nl:/usr/src/sys/arch/alpha/compile/AZENOMEI2.0 alpha
Architecture: alpha
Machine: alpha
>Description:
	Audio never worked on Alpha PWS (Miata) machines.
	Then around 10 januari I found a patch that made it work.
	I tried to find the originator to confirm it to hir but I must
	have lost the original message; I can't find it anymore.
	There is no sign of a similar patch in gnats that I can find,
	hence this pr to keep the information.

	This patches the audio so that it works via the ess device;
	the audio is afaik also supposed to work as a soundblaster but
	that never worked for me either.
>How-To-Repeat:
	Try to use sound. Hear silence and see strange messages in syslog.
>Fix:

Like I said, not my patch, I can't give credit to whom it is due.
This patch is for the 2.0 branch, I notice that in -current there are
some changes in essreg.h but it doesn't incorporate this difference.

(in fact it seems that ESS_USE_AUDIO1(model) is after the patch now true
for all supported ess models??)

--- essreg.h.orig	2001-09-29 21:08:49.000000000 +0200
+++ essreg.h	2005-01-10 23:21:15.000000000 +0100
@@ -175,7 +175,7 @@
 
 #define ESS_DRQ2_VALID(chan) ((chan) == 0 || (chan) == 1 || (chan) == 3 || (chan) == 5)
 
-#define ESS_USE_AUDIO1(model) (((model) == ESS_1788) || ((model) == ESS_1868) || ((model) == ESS_1878) || ((model) == ESS_1869) || ((model) == ESS_1879))
+#define ESS_USE_AUDIO1(model) (((model) == ESS_1788) || ((model) == ESS_1868) || ((model) == ESS_1878) || ((model) == ESS_1869) || ((model) == ESS_1879) || ((model) == ESS_1888))
 
 /*
  * Macros to manipulate gain values
--- ess.c.orig	2003-05-10 01:51:28.000000000 +0200
+++ ess.c	2005-01-10 23:21:15.000000000 +0100
@@ -249,7 +249,7 @@
 	NULL,
 	NULL,
 	NULL,
-	ess_audio2_halt,
+	ess_audio1_halt,
 	ess_audio1_halt,
 	ess_speaker_ctl,
 	ess_getdev,
@@ -262,7 +262,7 @@
 	ess_round_buffersize,
 	ess_mappage,
 	ess_1888_get_props,
-	ess_audio2_trigger_output,
+	ess_audio1_trigger_output,
 	ess_audio1_trigger_input,
 	NULL,
 };

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert                            --  rhialto/at/falu.nl
\X/ Hi! I'm a signature virus! Copy me to your .signature to help me spread!