Subject: xsrc/29003: Re: xsrc/29003: Bug in xterm (fwd)
To: None <xsrc-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Matthias Scheler <tron@NetBSD.org>
List: netbsd-bugs
Date: 01/19/2005 07:43:01
The following reply was made to PR xsrc/29003; it has been noted by GNATS.

From: Matthias Scheler <tron@NetBSD.org>
To: Thomas Dickey <dickey@his.com>
Cc: NetBSD GNATS <gnats-bugs@netbsd.org>
Subject: Re: xsrc/29003: Bug in xterm (fwd)
Date: Wed, 19 Jan 2005 07:42:16 +0000

 On Tue, Jan 18, 2005 at 06:46:19PM -0500, Thomas Dickey wrote:
 > I hadn't seen that one (there were a lot of changes in #171 a couple of 
 > years ago, mostly good but a few bugs).  A quick check shows 21 places in 
 > the state table that can get there, including the default ansi_table. 
 > That one looks like an error; the others I'll have to sift through and 
 > check for other possible errors).  The
 > 
 >             if (!string_used)
 >                 break;
 > 
 > does guard against most errors.
 > 
 > Resetting the state to ground at the beginning does ensure that the check 
 > if there's no string_used doesn't prevent the state from resetting 
 > (agree).
 
 To be sure I get this right: the fix is worth committing?
 
 	Kind regards
 
 -- 
 Matthias Scheler                                  http://scheler.de/~matthias/