Subject: port-i386/26630: essattach() in ess_pnpbios.c out of sync
To: None <>
From: None <>
List: netbsd-bugs
Date: 08/12/2004 08:48:10
>Number:         26630
>Category:       port-i386
>Synopsis:       essattach() in ess_pnpbios.c out of sync
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-i386-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 12 18:34:00 UTC 2004
>Originator:     George F. Costanzo
>Release:        NetBSD 2.0G
NetBSD 2.0G NetBSD 2.0G (SARIG) #63: Fri Jul 16 01:22:29 EST 2004 i386
Seems /usr/src/sys/arch/i386/pnpbios/ess_pnpbios.c calls essattach() with the incorrect amount of arguments since drochner commited rev 1.19 of /usr/src/sys/dev/isa/essvar.h. This prevents the kernel being built with the error:

#   compile  SARIG/ess_pnpbios.o
/usr/tools.i386/bin/i386--netbsdelf-gcc -ffreestanding -O2 -Werror -Wall -Wno-main -Wno-format-zero-length
-Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wno-sign-compare -fno-zero-initialized-in-bss -Di386 -I.
-I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DDUMMY_NOPS -DNMBCLUSTERS=2048 -DUCONSOLE -DLKM -DMAXUSERS=12 -D_KERNEL
-D_KERNEL_OPT -c /usr/src/sys/arch/i386/pnpbios/ess_pnpbios.c
/usr/src/sys/arch/i386/pnpbios/ess_pnpbios.c: In function `ess_pnpbios_attach':
/usr/src/sys/arch/i386/pnpbios/ess_pnpbios.c:143: error: too few arguments to function `essattach'

*** Failed target:  ess_pnpbios.o

ess*            at pnpbios? index ?     # ESS AudioDrive
./ kernel
--- sys/arch/i386/pnpbios/ess_pnpbios.c.orig    2004-08-12 21:01:28.000000000 +1000
+++ sys/arch/i386/pnpbios/ess_pnpbios.c 2004-08-12 21:01:47.000000000 +1000
@@ -140,6 +140,6 @@
-       essattach(sc);
+       essattach(sc, 0);