Subject: standards/25058: netinet/tcp.h missing TH_ECE and TH_CWR flags
To: None <>
From: None <>
List: netbsd-bugs
Date: 04/04/2004 22:04:33
>Number:         25058
>Category:       standards
>Synopsis:       netinet/tcp.h missing TH_ECE and TH_CWR flags
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    standards-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 05 02:05:00 UTC 2004
>Originator:     Chuck Swiger
>Release:        NetBSD-1.6.2
System: NetBSD netter 1.6.2 NetBSD 1.6.2 (GENERIC) #0: Tue Feb 10 21:53:10 UTC
2004 i386
Architecture: i386
Machine: i386

netinet/tcp.h is missing flags defined by RFC-2481, -3168, et. al.

Whether NetBSD supports (or should support) ECN is a seperate question, but
NetBSD systems are still going to receive packets with these bits set, and it
would be nice if the system headers contained definitions for them.

Patch included below.



--- /usr/include/netinet/tcp.h  Tue Feb 10 13:45:27 2004
+++ tcp.h       Fri Mar 2 06:26:53 2004
@@ -65,6 +65,8 @@
 #define        TH_PUSH   0x08
 #define        TH_ACK    0x10
 #define        TH_URG    0x20
+#define        TH_ECE    0x40
+#define        TH_CWR    0x80
        u_int16_t th_win;                       /* window */
        u_int16_t th_sum;                       /* checksum */
        u_int16_t th_urp;                       /* urgent pointer */