Subject: kern/24859: Redundant i830 agp aperture size display at boot
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <njoly@pasteur.fr>
List: netbsd-bugs
Date: 03/20/2004 12:43:37
>Number:         24859
>Category:       kern
>Synopsis:       Redundant i830 agp aperture size display at boot
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 20 11:44:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Nicolas Joly
>Release:        NetBSD 1.6ZK (-current 20040320)
>Organization:
	Institut Pasteur
>Environment:
System: NetBSD calamity.sis.pasteur.fr 1.6ZK NetBSD 1.6ZK (CALAMITY) #9: Sat Mar 20 10:23:59 CET 2004 njoly@calamity.sis.pasteur.fr:/local/src/NetBSD/obj/i386/sys/arch/i386/compile/CALAMITY i386
Architecture: i386
Machine: i386
>Description:
At boot, my Dell Inspiron 2600 laptop print 3 lines for i830 agp :

agp0 at pchb0: detected 8060k stolen memory
agp0: aperture size is 128M
agp0: aperture at 0xe8000000, size 0x8000000

But the 2nd is useless, and can be removed, as aperture size is also printed
later on the 3rd line.

>How-To-Repeat:
Check agp i830 (and probably i855) boot messages.
>Fix:

Index: sys/dev/pci/agp_i810.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/agp_i810.c,v
retrieving revision 1.21
diff -u -r1.21 agp_i810.c
--- sys/dev/pci/agp_i810.c	23 Dec 2003 19:56:58 -0000	1.21
+++ sys/dev/pci/agp_i810.c	20 Mar 2004 11:31:43 -0000
@@ -253,9 +253,6 @@
 			aprint_error(": detected %dk stolen memory\n%s",
 			    isc->stolen * 4, sc->as_dev.dv_xname);
 		}
-		aprint_error(": aperture size is %dM\n%s",
-		       isc->initial_aperture / 1024 / 1024,
-		       sc->as_dev.dv_xname);
 
 		/* GATT address is already in there, make sure it's enabled */
 		pgtblctl = READ4(AGP_I810_PGTBL_CTL);
@@ -298,9 +295,6 @@
 			aprint_error(": detected %dk stolen memory\n%s",
 			    isc->stolen * 4, sc->as_dev.dv_xname);
 		}
-		aprint_error(": aperture size is %dM\n%s",
-			isc->initial_aperture / 1024 / 1024,
-			sc->as_dev.dv_xname);
 
 		/* GATT address is already in there, make sure it's enabled */
 		pgtblctl = READ4(AGP_I810_PGTBL_CTL);
>Release-Note:
>Audit-Trail:
>Unformatted: