Subject: pkg/24766: pkgsrc/print/teTeX-share assumes _PATCH_BACKUP_ARG being set
To: None <>
From: None <>
List: netbsd-bugs
Date: 03/13/2004 19:18:52
>Number:         24766
>Category:       pkg
>Synopsis:       pkgsrc/print/teTeX-share assumes _PATCH_BACKUP_ARG being set
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 13 19:19:00 UTC 2004
>Originator:     Georg Schwarz
>Release:        current pkgsrc
IRIX lorenz 5.3 08031225 IP20 mips
pkgsrc/print/teTeX-share/Makefile makes use of _PATCH_BACKUP_ARG. However, this variable is not necesarily set on every platform (depends on  _PATCH_CAN_BACKUP).

The same problem seems to exist for print/acroread/Makefile, print/acroread3/Makefile, print/acroread5/Makefile, print/teTeX1-share/Makefile, print/teTeX1-sharesrc/Makefile

The Makefile features USE_GNU_TOOLS+= patch, so (please correct me if I am wrong) we can assume that ${PATCH} later on is always GNU patch.
One solution would be to modify the tools scripts under pkgsrc/mk to set  and _PATCH_BACKUP_ARG accordingly when GNU patch is enforced.
The other solution would be not to use _PATCH_BACKUP_ARG in pkgsrc/print/teTeX-share/Makefile but instead directly the arguments appropriate for the GNU version of patch (-b -V simple -z I think), since we can assume we do use GNU patch anyway.
The issue is whether any Makefile can and should assume variables such a _PATCH_BACKUP_ARG being set.