Subject: pkg/24355: editors/jed won't build on FreeBSD-current because of FreeBSD so-called "Posix" compatibility; fix included
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <dotz@irc.pl>
List: netbsd-bugs
Date: 02/08/2004 03:36:26
>Number:         24355
>Category:       pkg
>Synopsis:       editors/jed won't build on FreeBSD-current because of FreeBSD so-called "Posix" compatibility; fix included
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 08 03:37:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Michal Pasternak
>Release:        N/A
>Organization:
>Environment:
FreeBSD fbsd-cnt.w.lub.pl 5.2.1-RC FreeBSD 5.2.1-RC #0: Sat Jan 31 05:36:22 GMT 2004     root@cypress.btc.adpatec.com:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
Some jed functionality depends on grantpt.

FreeBSD-4 doesn't have it, jed works and builds there.

FreeBSD-5 has, but some POSIX stuff is only partial implemented there:
no http://www.opengroup.org/onlinepubs/007908799/xsh/ioctl.html and no
http://www.opengroup.org/onlinepubs/007908799/xsh/stropts.h.html

So, jed fails while compiling jprocess.c
>How-To-Repeat:
Get FreeBSD-current, compile jed editor.

Sorry for not providing failure build log, but try to understand, I have
jed compiled & working, I don't want to break things just to 
demonstrate.

xtraeme@netbsd.org propably uses pkgsrc on FreeBSD-current and can 
confirm this.
>Fix:
Well, we can use such lame patch, which is also used by FreeBSD Ports.

See for yourself:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/editors/jed/files/

Jed compiled with it works & builds okay on both FreeBSDs.

The patch doesn't affect other OS'.

Please place the below lines as editors/jed/patches/patch-aa or 
editors/jed/patches/patch-ac

Sorry for not providing the diffs, but anoncvs.netbsd.org is DOWN AGAIN,
and I am quite tired with searching a working mirror.

The patch:
$NetBSD$

--- src/jprocess.c.orig Sun Feb  8 04:19:02 2004
+++ src/jprocess.c
@@ -58,7 +58,9 @@
 
 #ifdef REALLY_HAVE_TERMIOS_H
 # ifndef __os2__
-#  define USE_PTY
+#  ifndef __FreeBSD__
+#   define USE_PTY
+#  endif
 # endif
 #endif
 

>Release-Note:
>Audit-Trail:
>Unformatted: