Subject: pkg/24111: subversion build fails on systems without NLS
To: None <>
From: None <>
List: netbsd-bugs
Date: 01/15/2004 19:40:22
>Number:         24111
>Category:       pkg
>Synopsis:       devel/subversion build fails on systems without NLS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 15 17:45:00 UTC 2004
>Originator:     Jorge Acereda
>Release:        NetBSD 1.6ZG
System: NetBSD locus.dlsi 1.6ZG NetBSD 1.6ZG (LOCUS) #32: Mon Dec 22 16:41:55 CET 2003 root@locus.dlsi:/sys/arch/i386/compile/LOCUS i386
Architecture: i386
Machine: i386

devel/subversion dumps core in the install stage on systems compiled
with MKNLS=no


I think it should suffice to do the following on a normal system to
simulate missing NLS and see the error:

# mv /usr/share/i18n /usr/share/i18n.unused
# cd /usr/pkgsrc/devel/subversion && make install
# mv /usr/share/i18n.unused /usr/share/i18n

The core dump is caused by an infinite recursion, the following patch
solves it. The subversion maintainers might come up with a better

--- subversion/libsvn_subr/utf.c.orig	2004-01-15 19:12:49.000000000 +0100
+++ subversion/libsvn_subr/utf.c
@@ -65,7 +65,9 @@ get_xlate_handle (apr_xlate_t **ret,
   /* Try to create one. */
   apr_err = apr_xlate_open (ret, topage, frompage, pool);
-  if (APR_STATUS_IS_EINVAL (apr_err) || APR_STATUS_IS_ENOTIMPL (apr_err))
+  if (   APR_STATUS_IS_EINVAL (apr_err) 
+      || APR_STATUS_IS_ENOTIMPL (apr_err)
+      || APR_STATUS_IS_ENOENT (apr_err))
       *ret = NULL;
       return SVN_NO_ERROR;