Subject: pkg/23882: emulators/wine: bad ONLY_FOR_PLATFORM entry
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <dotz@irc.pl>
List: netbsd-bugs
Date: 12/25/2003 10:28:40
>Number:         23882
>Category:       pkg
>Synopsis:       emulators/wine: bad ONLY_FOR_PLATFORM entry
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 25 10:29:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Michal Pasternak
>Release:        N/A
>Organization:
>Environment:
N/A
>Description:
At www.winehq.com you can read:

	(...) and a program loader, allowing many unmodified Windows
	binaries to run on x86-based Unixes, including Linux, FreeBSD,
	and Solaris.

In emulators/wine/Makefile you can read:

	ONLY_FOR_PLATFORM=     NetBSD-1.5Z*-i386 NetBSD-1.[6-9]*-i386

>How-To-Repeat:
N/A
>Fix:
What was the purpose of such ONLY_FOR_PLATFORM setting?

I think, that in the past someone tried to forbid wine port for 
old (1.4?) NetBSD release.

But this is no longer needed: please apply this diff, please think 
about NetBSD 2.0 while changing this -- maybe it would be better
to use just ONLY_FOR_PLATFORM= *-*-i386 ? (who does use NetBSD 1.4
these days anyway? -- and WineHQ descr looks like Wine should be 
portable to other x86 unices)

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/emulators/wine/Makefile,v
retrieving revision 1.55
diff -u -r1.55 Makefile
--- Makefile    1 Dec 2003 15:59:50 -0000       1.55
+++ Makefile    25 Dec 2003 10:16:12 -0000
@@ -14,7 +14,7 @@
 
 CONFLICTS=             rewind-[0-9]*
 
-ONLY_FOR_PLATFORM=     NetBSD-1.5Z*-i386 NetBSD-1.[6-9]*-i386
+ONLY_FOR_PLATFORM=     NetBSD-1.5Z*-i386 NetBSD-1.[6-9]*-i386 FreeBSD*-i386 Linux*-i386 Solaris*-i386
 
 USE_BUILDLINK2=                YES
 USE_X11=               YES

>Release-Note:
>Audit-Trail:
>Unformatted: