Subject: pkg/23843: x11/xscreensaver doesn't compile on FreeBSD; trival fix
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <dotz@irc.pl>
List: netbsd-bugs
Date: 12/22/2003 18:15:35
>Number:         23843
>Category:       pkg
>Synopsis:       x11/xscreensaver doesn't compile on FreeBSD; trival fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 22 18:16:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Michal Pasternak
>Release:        N/A
>Organization:
Good people with bad reputation
>Environment:
FreeBSD mainframe.w.lub.pl 4.9-RELEASE FreeBSD 4.9-RELEASE #0: Mon Oct 27 17:51:09 GMT 2003     root@freebsd-stable.sentex.ca:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
x11/xscreensaver while compiling it on FreeBSD will break at:

In file included from passwd-pwent.c:19:
/usr/include/stdlib.h:111: warning: ANSI C does not support `long long'
/usr/include/stdlib.h:117: warning: ANSI C does not support `long long'
cc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -std=c89 -U__STRICT_ANSI__ -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -liconv -L/usr/X11R6/lib -Wl,-R/usr/X11R6/lib -L/usr/X11R6/lib -o xscreensaver xscreensaver.o windows.o timers.o subprocs.o exec.o  xset.o splash.o setuid.o stderr.o prefs.o dpms.o lock.o passwd.o passwd-pam.o passwd-pwent.o  ../utils/fade.o ../utils/overlay.o  ../utils/logo.o ../utils/yarandom.o  ../utils/resources.o ../utils/usleep.o  ../utils/visual.o    -L/usr/pkg/lib -L/usr/pkg/lib  -L/usr/X11R6/lib -lXmu  -lXss -lXinerama -lXxf86vm -lXxf86misc    -lXt -lSM -lICE  -lXt -lX11 -lXext   -lpam -lcrypt
passwd-pam.o: In function `pam_passwd_valid_p':
passwd-pam.o(.text+0x15c): undefined reference to `sigtimedwait'
passwd-pam.o(.text+0x27b): undefined reference to `sigtimedwait'
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/x11/xscreensaver/work/xscreensaver-4.14/driver
*** Error code 5

Stop.
bmake: stopped in /usr/pkgsrc/x11/xscreensaver/work/xscreensaver-4.14
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/x11/xscreensaver
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/x11/xscreensaver

>How-To-Repeat:
Obvious.
>Fix:
Apply this patch to x11/xscreensaver/Makefile.common. xscreensaver from FreeBSD Ports uses the same option, both for xscreensaver and xscreensaver-gnome, so I guess this is not a problem to commit. 

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xscreensaver/Makefile.common,v
retrieving revision 1.58
diff -u -r1.58 Makefile.common
--- Makefile.common     13 Dec 2003 19:22:12 -0000      1.58
+++ Makefile.common     22 Dec 2003 18:10:21 -0000
@@ -55,5 +55,9 @@
 USE_PKGSRC_GCC=                # defined
 .endif
 
+.if ${OPSYS} == "FreeBSD"
+CONFIGURE_ARGS+=       --without-pam
+.endif
+
 .include "../../graphics/gle/buildlink2.mk"
 .include "../../graphics/jpeg/buildlink2.mk"

>Release-Note:
>Audit-Trail:
>Unformatted: