Subject: pkg/23676: Bug in /usr/pkgsrc/mk/apache.mk, rev 1.4
To: NetBSD Gnats system <gnats-bugs@gnats.netbsd.org>
From: Aidan Kehoe <aidan.kehoe@phorest.ie>
List: netbsd-bugs
Date: 12/06/2003 18:31:28
>Number:         23676
>Category:       pkg
>Synopsis:       Bad variable assignment, line 127, /usr/pkgsrc/mk/apache.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 06 18:32:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Aidan Kehoe
>Release:        NetBSD 1.6ZD
>Organization:

Aidan Kehoe
Technical Officer
nDevor Systems Ltd

Email: aidan.kehoe@phorest.ie
Mobile: +353 86 3874935 
Phone: +353 1 8729673 (GMT office hours)
Physical: 69 Middle Abbey Street, Dublin 1, Ireland
Web: http://www.phorest.com/
>Environment:
System: NetBSD smiley 1.6ZD NetBSD 1.6ZD (SMILEY) #: Fri Oct 17 09:51:15 IST 2003 aidan@smiley:/usr/obj/sys/arch/i386/compile/SMILEY i386
Architecture: i386
Machine: i386
>Description:

smiley	[ cd /usr/pkgsrc/www/ap-php4
smiley  [ make clean
make: Unknown modifier '$'
make: Unknown modifier '$'
make: Unknown modifier '$'
===> Cleaning for ap-php-4.3.4
smiley	[ 

Then I make the change mentioned in my fix; 

smiley  [ diff -u /usr/pkgsrc/mk/apache.mk{\?rev=1.4,}
smiley  [ make clean
===> Cleaning for ap-php-4.3.4
smiley  [ 

	
>How-To-Repeat:

Try to compile PHP as an Apache server module, fail. I'm getting other issues
with it now--libtool--but the above will bear fixing anyway. 

>Fix:

--- /usr/pkgsrc/mk/apache.mk?rev=1.4    2003-12-06 18:19:51.000000000 +0000
+++ /usr/pkgsrc/mk/apache.mk    2003-12-06 18:22:59.000000000 +0000
@@ -124,7 +124,7 @@
 
 _APACHE_BL_SRCDIR?=    ../../www/apache
 
-_APACHE_DEPENDENCY?=   ${BUILDLINK_DEPENDS.${_PKG_APACHE}:${_APACHE_PKGSRCDIR}
+_APACHE_DEPENDENCY?=   ${BUILDLINK_DEPENDS.${_PKG_APACHE}}:${_APACHE_PKGSRCDIR}
 
 # Add a runtime dependency on the apache server.
 # This may or may not create an actual dependency depending on
>Release-Note:
>Audit-Trail:
>Unformatted: