>Number:         23612
>Category:       pkg
>Synopsis:       graphics/mplayer-1.0rc1nb1 fails to build in rare cases
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 01 21:16:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6.1
>Organization:
>Environment:
System: NetBSD tri 1.6.1 NetBSD 1.6.1 (TRI) #6: Sun Nov 2 18:10:02 CET 2003 root@tri:/usr/src/sys/arch/i386/compile/TRI i386
Architecture: i386
Machine: i386
cpuflags: -march=pentium
>Description:
	When MPLAYER_ENABLE_RUNTIME_CPU_DETECTION is set to NO in /etc/mk.conf
	and if one's CPU does not have MMX support, building mplayer-1.0rc1nb1
	fails with an unresolved symbol because the project source
	mplayer-1.0pre1/libmpcodecs/pullup.c found in MPlayer-1.0pre1.tar.bz2
	does not define function licomb_y_mmx if HAS_MMX is not defined, but is
	still called by function licomb_y_test.
>How-To-Repeat:
	Find an old CPU without MMX support, insert
	MPLAYER_ENABLE_RUNTIME_CPU_DETECTION=NO
	in /etc/mk
	cd pkgsrc/graphics/mplayer ; make

	I know this is not a pkgsrc related bug, but I though the fix would
	have it's place before the freeze ends and 1.6.2 is released.
>Fix:
	cd pkgsrc/graphics/mplayer ; make patch
	cd work/mplayer-1.0pre1/libmpcodecs
	mv pullup.c pullup.c.orig
	sed '172 s/^/#ifdef HAS_MMX/; 180 s/^/#endif/' pullup.c.orig >pullup.c
	cd ../../.. ; make

	N.B. I have made this patch available (without revision IDs) at :
	http://bsd4ever.free.fr/libmpcodecs_pullup.c.patch
>Release-Note:
>Audit-Trail:
>Unformatted: