Subject: pkg/23457: games/quake does not need USE_X11BASE
To: None <gnats-bugs@gnats.netbsd.org>
From: None <snj@pobox.com>
List: netbsd-bugs
Date: 11/16/2003 07:45:34
>Number:         23457
>Category:       pkg
>Synopsis:       games/quake does not need USE_X11BASE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 16 07:46:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Soren Jacobsen
>Release:        NetBSD 1.6.1
>Organization:
>Environment:
pkgsrc as of 11/15/2003.
>Description:
There is no reason to install quake in ${X11PREFIX}. Bump PKGREVISION
for this.
In addition, remove post-install target and INSTALL script and replace them
with a MESSAGE file. The information contained in both of those has been
changed to something more helpful.
>How-To-Repeat:
>Fix:
Delete INSTALL and add MESSAGE: 
===========================================================================
$NetBSD$

To run quake you need data files. The quakedata package, which contains
the shareware data, has been installed.

To start a game, run quake.x11 from a directory that contains
id1/pak0.pak, for example, ${LOCALBASE}/share/quake/.
===========================================================================

Patch for the rest:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/games/quake/Makefile,v
retrieving revision 1.25
diff -u -r1.25 Makefile
--- Makefile	2003/07/21 16:49:59	1.25
+++ Makefile	2003/11/16 07:38:20
@@ -2,7 +2,7 @@
 
 DISTNAME=	q1source
 PKGNAME=	quake-2.30
-PKGREVISION=	1
+PKGREVISION=	2
 WRKSRC=		${WRKDIR}
 CATEGORIES=	games x11
 MASTER_SITES=	ftp://ftp.fu-berlin.de/pc/msdos/games/idgames/idstuff/source/ \
@@ -21,7 +21,7 @@
 USE_GMAKE=	yes
 MAKE_ENV+=	MAINDIR=${WRKSRC}
 
-USE_X11BASE=	yes
+USE_X11=	yes
 
 MAKE_ENV+=	MESA_DIR=${BUILDLINK_PREFIX.Mesa}
 MAKE_ENV+=	X11BASE=${X11BASE}
@@ -47,14 +47,6 @@
 	${INSTALL_PROGRAM} ${WRKSRC}/qw/release_version/glqwcl.glx ${PREFIX}/bin
 	${INSTALL_PROGRAM} ${WRKSRC}/winquake/release_version/bin/glquake.glx ${PREFIX}/bin
 	${INSTALL_PROGRAM} ${WRKSRC}/winquake/release_version/bin/quake.x11 ${PREFIX}/bin
-
-post-install:
-	@ ${ECHO}
-	@ ${ECHO} =====================================================================
-	@ ${ECHO} For running quake you need data files. Look for quakesw-1.0.6.tar.gz.
-	@ ${ECHO} Extract it somewhere, and start quake from the same directory, e.g.
-	@ ${ECHO} by running \'quake.x11\'.
-	@ ${ECHO} =====================================================================
 
 .include "../../graphics/MesaLib/buildlink2.mk"
 .include "../../graphics/glu/buildlink2.mk"
>Release-Note:
>Audit-Trail:
>Unformatted: