>Number:         23232
>Category:       pkg
>Synopsis:       chat/irssi does not work as built
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 22 16:10:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Paul Dokas
>Release:        NetBSD 1.6ZC
>Organization:
Department of Computer Science, University of Minnesota
>Environment:
System: NetBSD caligula 1.6ZC NetBSD 1.6ZC (CALIGULA) #2: Thu Oct 9 17:34:05 CDT 2003 root@caligula:/big/src/sys/arch/i386/compile/CALIGULA i386
Architecture: i386
Machine: i386
>Description:

As it sits in pkgsrc, chat/irssi does not work when build and installed.
When build and run, it claims to be unable to bind any sockets.  Undoing
the bind portion of patch-ad fixes it.


>How-To-Repeat:

  cd pkgsrc/chat/irssi
  make install
  su - user
  /usr/pkg/bin/irssi

>Fix:

Remove the following portion of patch-ad:

--- src/core/network.c.orig     Mon Aug 26 21:10:02 2002
+++ src/core/network.c
@@ -201,10 +201,13 @@ GIOChannel *net_connect_ip(IPADDR *ip, i
        /* set our own address */
        if (my_ip != NULL) {
                sin_set_ip(&so, my_ip);
-               if (bind(handle, &so.sa, SIZEOF_SOCKADDR(so)) == -1) {
+               if (bind(handle, &so.sa, SIZEOF_SOCKADDR(so)) < 0) {
                        /* failed, set it back to INADDR_ANY */
-                       sin_set_ip(&so, NULL);
-                       bind(handle, &so.sa, SIZEOF_SOCKADDR(so));
+                       int old_errno = errno;
+
+                       close(handle);
+                       errno = old_errno;
+                       return NULL;
                }
        }


>Release-Note:
>Audit-Trail:
>Unformatted: