>Number:         22942
>Category:       pkg
>Synopsis:       audio/lib{ogg,vorbis} need .include of compiler.mk removed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 24 21:50:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Todd Vierling
>Release:        NetBSD 1.6.1_STABLE
>Organization:
	DUH.ORG:  Pointing out the obvious since 1994.
>Environment:
System: NetBSD server.duh.org 1.6.1_STABLE NetBSD 1.6.1_STABLE (SERVER) #1: Fri Sep 12 11:28:14 EDT 2003 tv@server.duh.org:/export/SRC/duh/netbsd-kernels/SERVER i386
Architecture: i386
Machine: i386
>Description:

audio/lib{ogg,vorbis}/Makefile explicitly include ../../mk/compiler.mk,
and don't include bsd.prefs.mk, causing disaster.

>How-To-Repeat:

$ cd /usr/pkgsrc/audio/libogg && make clean
-q: not found
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 61: warning: Couldn't read shell's output for "if cc -v 2>&1 |  -q 'gcc version'; then  echo `cc -v 2>&1 |  'gcc version'`;  fi"
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 105: Malformed conditional (defined(USE_GCC2) && empty(PKGPATH:Mlang/gcc) && empty(_PKGSRC_DEPS:Mgcc-2*))
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 105: Missing dependency operator
not-defined: not found
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 117: warning: "if [ -x /gcc-2.95.3/bin/gcc ]; then                            dirname `/gcc-2.95.3/bin/gcc --print-libgcc-file-name`;         else                                                             not-defined;                                   fi" returned non-zero status
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 142: Malformed conditional (defined(USE_GCC3) && empty(PKGPATH:Mlang/gcc3) && empty(_PKGSRC_DEPS:Mgcc-3*))
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 142: Missing dependency operator
not-defined: not found
make: "/usr/pkgsrc/audio/libogg/../../mk/../lang/gcc3/buildlink2.mk" line 28: warning: "if [ -x /gcc-3.3/bin/gcc ]; then                                 dirname `/gcc-3.3/bin/gcc --print-libgcc-file-name`;    else                                                             not-defined;                                   fi" returned non-zero status
: permission denied
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 195: warning: "if /gcc-3.3/bin/gcc -dumpversion > /dev/null 2>&1; then   `/gcc-3.3/bin/gcc -dumpversion`;  else   "";  fi" returned non-zero status
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 209: if-less endif
make: "/usr/pkgsrc/audio/libogg/../../mk/compiler.mk" line 209: Need an operator
make: Fatal errors encountered -- cannot continue

make: stopped in /usr/pkgsrc/audio/libogg

>Fix:

Since bsd.prefx.mk now pulls in compiler.mk, remove the offending .include
lines from these Makefiles.
>Release-Note:
>Audit-Trail:
>Unformatted: