Subject: Re: pkg/22901: openjade won't build in -current
To: None <gnats-bugs@gnats.netbsd.org, netbsd-bugs@netbsd.org>
From: Michael van Elst <mlelstv@serpens.de>
List: netbsd-bugs
Date: 09/23/2003 09:41:01
That's a bug in opensp (not openjade) that triggers a stricter
C++ interpretation in GCC3.3. I have once fixed this with the
following patch:

--- include/Attribute.h.dist    2003-06-27 14:13:01.000000000 +0200
+++ include/Attribute.h 2003-06-27 14:15:54.000000000 +0200
@@ -31,6 +31,27 @@
 class AttributeContext;
 class Syntax;

+class SP_API AttributeValue : public Resource {
+public:
+  enum Type {
+    implied,
+    cdata,
+    tokenized
+    };
+  AttributeValue();
+  virtual ~AttributeValue();
+  virtual AttributeSemantics *makeSemantics(const DeclaredValue *,
+                       AttributeContext &,
+                       const StringC &,
+                       unsigned &,
+                       unsigned &) const;
+  virtual Type info(const Text *&, const StringC *&) const = 0;
+  virtual const Text *text() const;
+  virtual Boolean recoverUnquoted(const StringC &, const Location &,
+                 AttributeContext &, const StringC &);
+  static Boolean handleAsUnterminated(const Text &, AttributeContext
&);
+};
+
 class SP_API AttributeDefinitionDesc {
 public:
   AttributeDefinitionDesc() { }
@@ -380,27 +401,6 @@
   ConstPtr<Notation> notation_;
 };

-class SP_API AttributeValue : public Resource {
-public:
-  enum Type {
-    implied,
-    cdata,
-    tokenized
-    };
-  AttributeValue();
-  virtual ~AttributeValue();
-  virtual AttributeSemantics *makeSemantics(const DeclaredValue *,
-                       AttributeContext &,
-                       const StringC &,
-                       unsigned &,
-                       unsigned &) const;
-  virtual Type info(const Text *&, const StringC *&) const = 0;
-  virtual const Text *text() const;
-  virtual Boolean recoverUnquoted(const StringC &, const Location &,
-                 AttributeContext &, const StringC &);
-  static Boolean handleAsUnterminated(const Text &, AttributeContext
&);
-};
-
 class SP_API ImpliedAttributeValue : public AttributeValue {
 public:
   ImpliedAttributeValue();



-- 
                                Michael van Elst
Internet: mlelstv@serpens.de
                                "A potential Snark may lurk in every tree."