>Number:         22824
>Category:       pkg
>Synopsis:       pkgsrc/archivers/bzip2 does not specify libtool --mode
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 17 02:57:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Ron Roskens
>Release:        NetBSD 1.6W
>Organization:
	
>Environment:
	
	
System: NetBSD hysteria.tx.elfin.net 1.6W NetBSD 1.6W (GENERIC) #1: Mon Aug 18 22:11:25 UTC 2003 root@tidell.tx.elfin.net:/d/d1g/NetBSD/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
	
When using libtool-1.5 to build packages, the inference of which mode to
run in generates a warning.

*** Warning: inferring the mode of operation is deprecated.
*** Future versions of Libtool will require -mode=MODE be specified.

>How-To-Repeat:
# cd pkgsrc/archivers/bzip2 && make
	
>Fix:
	

Add "--mode=$mode" entries to the libtool usage.

Index: Makefile
===================================================================
RCS file: /cvs/NetBSD/pkgsrc/archivers/bzip2/Makefile,v
retrieving revision 1.24
diff -b -u -r1.24 Makefile
--- Makefile    17 Jul 2003 21:21:07 -0000      1.24
+++ Makefile    17 Sep 2003 02:30:47 -0000
@@ -34,6 +34,6 @@
        ${LN} -s ${PREFIX}/man/man1/bzip2.1 ${PREFIX}/man/man1/bzcat.1
        ${LN} -s ${PREFIX}/man/man1/bzip2.1 ${PREFIX}/man/man1/bzip2recover.1
        ${INSTALL_DATA} ${WRKSRC}/bzlib.h ${PREFIX}/include
-       ${LIBTOOL} ${INSTALL_DATA} ${WRKSRC}/libbz2.la ${PREFIX}/lib
+       ${LIBTOOL} --mode=install ${INSTALL_DATA} ${WRKSRC}/libbz2.la ${PREFIX}/lib
 
 .include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /cvs/NetBSD/pkgsrc/archivers/bzip2/distinfo,v
retrieving revision 1.7
diff -b -u -r1.7 distinfo
--- distinfo    18 Mar 2003 21:53:29 -0000      1.7
+++ distinfo    17 Sep 2003 02:37:36 -0000
@@ -2,4 +2,4 @@
 
 SHA1 (bzip2-1.0.2.tar.gz) = d47793959c0d65a4d7246e0247ed1358662d9ebf
 Size (bzip2-1.0.2.tar.gz) = 665198 bytes
-SHA1 (patch-aa) = 96899bad1878fbd0c556c0830d8a7a71ce724fc9
+SHA1 (patch-aa) = d902ac2a23f0b6f1b057f0e3637a06e844b9360b
cvs diff: Diffing patches
Index: patches/patch-aa
===================================================================
RCS file: /cvs/NetBSD/pkgsrc/archivers/bzip2/patches/patch-aa,v
retrieving revision 1.6
diff -b -u -r1.6 patch-aa
--- patches/patch-aa    18 Mar 2003 21:53:30 -0000      1.6
+++ patches/patch-aa    17 Sep 2003 02:37:30 -0000
@@ -7,8 +7,8 @@
  
  # To assist in cross-compiling
 -CC=gcc
-+CC=${LIBTOOL} ${REALCC}
-+LD=${LIBTOOL} ${REALCC}
++CC=${LIBTOOL} --mode=compile ${REALCC}
++LD=${LIBTOOL} --mode=link ${REALCC}
  AR=ar
  RANLIB=ranlib
 -LDFLAGS=
@@ -35,11 +35,11 @@
 -bzip2: libbz2.a bzip2.o
 -      $(CC) $(CFLAGS) $(LDFLAGS) -o bzip2 bzip2.o -L. -lbz2
 +bzip2: libbz2.la bzip2.o
-+      $(CC) $(CFLAGS) $(LDFLAGS) -static -o bzip2 bzip2.o libbz2.la
++      $(LD) $(CFLAGS) $(LDFLAGS) -static -o bzip2 bzip2.o libbz2.la
  
  bzip2recover: bzip2recover.o
 -      $(CC) $(CFLAGS) $(LDFLAGS) -o bzip2recover bzip2recover.o
-+      $(CC) $(CFLAGS) $(LDFLAGS) -static -o bzip2recover bzip2recover.o
++      $(LD) $(CFLAGS) $(LDFLAGS) -static -o bzip2recover bzip2recover.o
  
 -libbz2.a: $(OBJS)
 -      rm -f libbz2.a

>Release-Note:
>Audit-Trail:
>Unformatted: