Subject: pkg/22793: graphics/qiv doesn't respect pkgsrc CFLAGS
To: None <gnats-bugs@gnats.netbsd.org>
From: None <soren@lothar.blef.org>
List: netbsd-bugs
Date: 09/14/2003 12:56:25
>Number:         22793
>Category:       pkg
>Synopsis:       graphics/qiv doesn't respect pkgsrc CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 14 19:57:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Soren Jacobsen
>Release:        NetBSD 1.6ZB
>Organization:
>Environment:
pkgsrc as of 09/14/2003.
>Description:
qiv's Makefile explicitly sets CFLAGS.
>How-To-Repeat:
Compile qiv. Notice that it isn't using your CFLAGS.
>Fix:

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/qiv/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo	2002/09/11 18:18:20	1.3
+++ distinfo	2003/09/14 19:54:13
@@ -2,4 +2,4 @@
 
 SHA1 (qiv-1.8-src.tgz) = 33112bac34e5013d89cd4fa2997141820e8353ff
 Size (qiv-1.8-src.tgz) = 90886 bytes
-SHA1 (patch-aa) = 9b9386e5d12f4d99a5fc46def908aaa0ad060ee8
+SHA1 (patch-aa) = 168fb8e3e1ee44d00dda397d672831e58eb8005a
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/qiv/patches/patch-aa,v
retrieving revision 1.2
diff -u -r1.2 patch-aa
--- patches/patch-aa	2002/09/11 18:18:21	1.2
+++ patches/patch-aa	2003/09/14 19:54:13
@@ -1,7 +1,7 @@
 $NetBSD: patch-aa,v 1.2 2002/09/11 18:18:21 wiz Exp $
 
---- Makefile.orig	Sun Jun 10 14:35:06 2001
-+++ Makefile
+--- Makefile.orig	2001-06-10 05:35:06.000000000 -0700
++++ Makefile	2003-09-14 12:52:01.000000000 -0700
 @@ -4,7 +4,7 @@
  ######################################################################
  
@@ -24,6 +24,15 @@
 +COMPRESS_PROG = true
  
  ######################################################################
+ 
+@@ -54,7 +54,7 @@
+ ######################################################################
+ 
+ CC        = gcc
+-CFLAGS    = -O2 -Wall -fomit-frame-pointer -finline-functions \
++CFLAGS    += -Wall -fomit-frame-pointer -finline-functions \
+ 	    -fcaller-saves -ffast-math -fno-strength-reduce \
+ 	    -fthread-jumps #-march=pentium #-DSTAT_MACROS_BROKEN
  
 @@ -112,13 +112,13 @@
  
>Release-Note:
>Audit-Trail:
>Unformatted: