Subject: pkg/22085: xemacs-packeges fetches too much after update
To: None <gnats-bugs@gnats.netbsd.org>
From: None <kre@munnari.OZ.AU>
List: netbsd-bugs
Date: 07/07/2003 19:35:12
>Number:         22085
>Category:       pkg
>Synopsis:       xemacs-packeges fetches too much after update
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 07 12:36:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Robert Elz
>Release:        NetBSD 1.6Q   (pkgsrc of 2003-07-07 (ie: now))
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 1.6Q NetBSD 1.6Q (JADE-HP) #0: Sun Mar 23 02:27:44 ICT 2003 kre@fuchsia.cs.mu.OZ.AU:/usr/obj/sys/JADE-HP i386
Architecture: i386
Machine: i386
>Description:
	editors/xemacs-packages has a DIST_SUBDIR that has the
	package version built into it.   For some packages that
	is the right thing to do, for this one, it isn't.

	All of the files that are fetched into the DIST_SUBDIR
	have their own version numbers, which are (for individual
	files) not necessarily updated nearly as frequently as the
	version of xemacs-packages itself (eg: the recent update
	from xemacs-packages-1.11 to xemacs-packages-1.12 resulted
	in 42 included files being updated (and 1 new one), whereas
	71 files remained untouched (and didn't really need to
	be fetched again).   Since the complete set of distfiles
	here is > 30MB, that's a fair bunch of unnecessary fetching.
>How-To-Repeat:
	By inspection, or by watching what happened when xemacs-packages
	was updated a week ago.
>Fix:
	Apply the following patch to the Makefile.
	Rename the distdir from xemacs-packages-1.12 to xemacs-packages
	"make distinfo" to update the distinfo file.

--- Makefile.was	Mon Jun 30 19:32:41 2003
+++ Makefile	Mon Jul  7 19:18:01 2003
@@ -127,9 +127,9 @@
 COMMENT=	Common elisp packages for xemacs 21
 
 DEPENDS+=	xemacs>=21.1.14:../../editors/xemacs
 
-DIST_SUBDIR=	${PKGNAME_NOREV}
+DIST_SUBDIR=	${PKGBASE}
 EXTRACT_ONLY=	# empty
 NO_BUILD=	yes
 
 .include "../../editors/xemacs/Makefile.pkg"
>Release-Note:
>Audit-Trail:
>Unformatted: