Subject: pkg/21732: EXTRACT_CMD.zip should overwrite existing files without prompting; diff provided
To: None <gnats-bugs@gnats.netbsd.org>
From: None <reed@reedmedia.net>
List: netbsd-bugs
Date: 05/30/2003 21:28:01
>Number:         21732
>Category:       pkg
>Synopsis:       EXTRACT_CMD.zip should overwrite existing files without prompting; diff provided
>Confidential:   yes
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat May 31 04:29:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6
>Organization:
http://bsd.reedmedia.net/
>Environment:
	
	
System: NetBSD rainier.reedmedia.net 1.6 NetBSD 1.6 (JCR-20020927) #3: Sat Sep 28 13:40:20 PDT 2002 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/JCR-20020927 i386
Architecture: i386
Machine: i386
>Description:
unzip may prompt to ask before replacing a file.
Should use -o.

In docbook I received:
/usr/pkg/bin/sudo install -d -o root -g wheel -m 555 /usr/pkg/share/sgml/docbook
/2.4.1
#
# 2.4.1:
#
Archive:  /usr/local/pkgsrc/distfiles/docbk241.zip
replace 241chg.txt? [y]es, [n]o, [A]ll, [N]one, [r]ename:
..
Archive:  /usr/local/pkgsrc/distfiles/docbk40.zip
replace 40chg.txt? [y]es, [n]o, [A]ll, [N]one, [r]ename:

(This was on 22/Apr/2003.)
>How-To-Repeat:
>Fix:
Index: mk/bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1186
diff -b -u -r1.1186 bsd.pkg.mk
--- mk/bsd.pkg.mk	2003/05/29 23:08:01	1.1186
+++ mk/bsd.pkg.mk	2003/05/31 04:22:57
@@ -1732,7 +1732,7 @@
 
 DOWNLOADED_DISTFILE=	$${extract_file}
 
-EXTRACT_CMD.zip?=	${LOCALBASE}/bin/unzip -Laq $${extract_file}
+EXTRACT_CMD.zip?=	${LOCALBASE}/bin/unzip -Laqo $${extract_file}
 EXTRACT_CMD.lha?=	${LOCALBASE}/bin/lha xq $${extract_file}
 EXTRACT_CMD.lzh?=	${EXTRACT_CMD.lha}
 EXTRACT_CMD.zoo?=	${LOCALBASE}/bin/unzoo -x $${extract_file}
>Release-Note:
>Audit-Trail:
>Unformatted: