Subject: pkg/21085: tcl-fbsql/Makefile semi-broken
To: None <gnats-bugs@gnats.netbsd.org>
From: None <dmcmahill@netbsd.org>
List: netbsd-bugs
Date: 04/10/2003 07:01:56
>Number:         21085
>Category:       pkg
>Synopsis:       tcl-fbsql/Makefile semi-broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 10 04:02:00 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Dan McMahill
>Release:        1.6
>Organization:
NetBSD
>Environment:
	
System: NetBSD cowboy-burt 1.4.3A NetBSD 1.4.3A (COWBOY-BURT) #1: Fri Jul 20 06:58:40 EDT 2001 dan@cowboy-burt:/mnt/syssrc-1-4/sys/arch/sparc/compile/COWBOY-BURT sparc


>Description:
a recent change to tcl-fbsql/Makefile has make this start showing up in   
the readme generation:

Can't open /usr/pkg/lib/tclConfig.sh
make: "/ftp/pub/NetBSD/NetBSD-current/pkgsrc/databases/tcl-fbsql/Makefile"
line 31: warning: ". /usr/pkg/lib/tclConfig.sh; echo $TCL_PACKAGE_PATH" 
returned non-zero status


thats from:
# Need here for $PREFIX
TCL_DIR!=               . ${PREFIX}/lib/tclConfig.sh; echo  $$TCL_PACKAGE_PATH
 
perhaps this should be protected with
.if exists(${PREFIX}/lib/tclConfig.sh)
.endif

You get lots of the above messages when you try and build the package if  
tcl hasn't been installed yet.

It also seems like there may be some PLIST problems because tclConfig.sh  
is used to figure out where to install fbsql.so to:    

do-install:
        @-${MKDIR} ${TCL_DIR}
        ${INSTALL_PROGRAM} ${WRKSRC}/fbsql.so ${TCL_DIR}

but PLIST is hard coded:

lib/tcl/fbsql.so

	
>How-To-Repeat:
without TCL installed,
cd databases/tcl-fbsql && make show-var VARNAME=PKGNAME

	
>Fix:
protect the TCL_DIR!= with .if exists() and add TCL_DIR to PLIST_SUBST (without
the PREFIX part).

	
>Release-Note:
>Audit-Trail:
>Unformatted: