Subject: xsrc/20551: Preprocessor goof in xfree/xc/config/cf/X11.tmpl
To: None <gnats-bugs@gnats.netbsd.org>
From: Christopher Richards <richards+netbsd@CS.Princeton.EDU>
List: netbsd-bugs
Date: 03/02/2003 09:29:07
>Number:         20551
>Category:       xsrc
>Synopsis:       Preprocessor goof in xfree/xc/config/cf/X11.tmpl
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    xsrc-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 02 06:30:00 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Christopher Richards
>Release:        NetBSD 1.6.1_RC2
>Organization:
 
>Environment:
	
	
System: NetBSD zembla.Princeton.EDU 1.6.1_RC2 NetBSD 1.6.1_RC2 (ZEMBLA) #4: Sat Mar 1 20:17:03 EST 2003 richards@zembla.Princeton.EDU:/usr/src/sys/arch/i386/compile/ZEMBLA i386
Architecture: i386
Machine: i386
>Description:
	
	The above-mentioned file uses "#if ... || ..." to test whether
	certain symbols are defined, resulting in warnings.

>How-To-Repeat:
	
	Update to 4.3.0 and do a build.

>Fix:
	
	Patch follows.

Index: X11.tmpl
===================================================================
RCS file: /cvsroot/xsrc/xfree/xc/config/cf/X11.tmpl,v
retrieving revision 1.4
diff -u -b -r1.4 X11.tmpl
--- X11.tmpl	2003/02/28 21:49:17	1.4
+++ X11.tmpl	2003/03/02 14:18:46
@@ -675,7 +675,7 @@
 #define CompressAllFonts	NO
 #endif
 #ifndef ThreadedX
-#if HasPosixThreads || HasCThreads
+#if defined(HasPosixThreads) || defined(HasCThreads)
 #define ThreadedX		YES	/* multi-threaded libraries */
 #else
 #define ThreadedX		NO
>Release-Note:
>Audit-Trail:
>Unformatted: