>Number:         20120
>Category:       toolchain
>Synopsis:       'build.sh sets' doesn't create necessary subdirectories in RELEASEDIR
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 30 03:23:01 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        NetBSD 1.6M sources from 20030130
>Organization:
>Environment:
>Description:

running 'build.sh sets' fails because necessary subdirectories in RELEASEDIR
are not created:

  ./build.sh -T /opt/tools -D /opt/dest -O /opt/obj -R /opt/release sets
  ===> DESTDIR path: /opt/dest
  ===> TOOLDIR path: /opt/tools
  ===> Updated /opt/tools/bin/nbmake-i386
  (cd /cvs/src/distrib/sets && /opt/tools/bin/nbmake maketars)
  /opt/tools/bin/nbmake checkflist
  DESTDIR=/opt/dest  MACHINE=i386 MACHINE_ARCH=i386  MAKE=/opt/tools/bin/nbmake MTREE=/opt/tools/bin/nbmtree PAX=/opt/tools/bin/nbpax sh /cvs/src/distrib/sets/checkflist 
  DESTDIR=/opt/dest  MACHINE=i386 MACHINE_ARCH=i386  MAKE=/opt/tools/bin/nbmake MTREE=/opt/tools/bin/nbmtree PAX=/opt/tools/bin/nbpax sh /cvs/src/distrib/sets/maketars -d /opt/dest   -N /cvs/src/etc  -t /opt/release/i386/binary/sets 
  Creating base.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/base.tgz: directory nonexistent
  Creating comp.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/comp.tgz: directory nonexistent
  Creating etc.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/etc.tgz: directory nonexistent
  Creating games.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/games.tgz: directory nonexistent
  Creating man.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/man.tgz: directory nonexistent
  Creating misc.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/misc.tgz: directory nonexistent
  Creating text.tgz
  /cvs/src/distrib/sets/maketars: cannot create /opt/release/i386/binary/sets/text.tgz: directory nonexistent
  *** Error code 14
  
  Stop.
  nbmake: stopped in /cvs/src/distrib/sets
  *** Error code 1
  
  Stop.
  nbmake: stopped in /cvs/src
  
  ERROR: failed to make sets
  *** BUILD ABORTED ***

>How-To-Repeat:

./build.sh distribution sets

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/src/Makefile,v
retrieving revision 1.199
diff -u -r1.199 Makefile
--- Makefile	2003/01/26 06:19:12	1.199
+++ Makefile	2003/01/30 11:16:29
@@ -245,6 +245,7 @@
 #
 
 sets:
+	(cd ${.CURDIR}/etc && ${MAKE} INSTALLATION_DIRS="binary binary/sets" snap_pre)
 	(cd ${.CURDIR}/distrib/sets && ${MAKE} maketars)
 
 #
Index: etc/Makefile
===================================================================
RCS file: /cvsroot/src/etc/Makefile,v
retrieving revision 1.244
diff -u -r1.244 Makefile
--- etc/Makefile	2003/01/09 16:57:45	1.244
+++ etc/Makefile	2003/01/30 11:16:34
@@ -74,7 +74,7 @@
 # MD Makefile.inc files can add to this.
 # NOTE: Parent directories must be listed before subdirectories.
 #
-INSTALLATION_DIRS=	binary binary/sets binary/kernel installation
+INSTALLATION_DIRS?=	binary binary/sets binary/kernel installation
 
 .if exists(etc.${MACHINE}/Makefile.inc)
 .include "etc.${MACHINE}/Makefile.inc"
>Release-Note:
>Audit-Trail:
>Unformatted: