>Number:         19967
>Category:       pkg
>Synopsis:       audio/mp3blaster doesn't build with native threading
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 20 14:21:00 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6M
>Organization:
	
>Environment:
	
	
System: NetBSD lucifer.ipv6.stack.nl 1.6M NetBSD 1.6M (LUCIFER) #8: Mon Jan 20 11:51:21 CET 2003 martijnb@lucifer.ipv6.stack.nl:/sys/arch/i386/compile/LUCIFER i386
Architecture: i386
Machine: i386
>Description:
	mp3blaster doesn't compile with native threading at the moment. It
	is currently being configured with an alternative buffering 
	technique (Written by yours truly) which uses specific pth calls, and
	therefore requires pth (and not native threading). It has not yet
	been ported to pthreads.

	The "standard" threading version works with native threading, but has
	serious performance issues with pth.

>How-To-Repeat:

	On a NetBSD system with native threading:

	cd audio/mp3blaster; make

	Watch how the configure script enables pth without checking for it
	(this bug has been reported to the original author, and will be 
	 fixed), and watch it try to use pth include files.

>Fix:

    The following patch will only enable the 'newthreads' scheme when
    pth is being used.

--- Makefile.org	Mon Jan 20 20:59:16 2003
+++ Makefile	Mon Jan 20 21:00:28 2003
@@ -16,10 +16,14 @@
 CONFIGURE_ARGS+="--with-cxxflags=${CXXFLAGS}" \
 		--with-curses \
 		--with-oggvorbis 
-		--enable-newthreads
 
 .include "../../audio/libvorbis/buildlink2.mk"
 .include "../../devel/ncurses/buildlink2.mk"
 .include "../../mk/ossaudio.buildlink2.mk"
 .include "../../mk/pthread.buildlink2.mk"
+
+.if defined(PTHREAD_TYPE) && (${PTHREAD_TYPE} == "pth")
+   CONFIGURE_ARGS+= --enable-newthreads
+.endif
+
 .include "../../mk/bsd.pkg.mk"
>Release-Note:
>Audit-Trail:
>Unformatted: