Subject: Re: pkg/18684: update audio/nas to 1.5
To: None <markd@netbsd.org, pkg-manager@netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 12/03/2002 03:22:45
I really Really REALLY dislike having to go back into the PRs I've
submitted and which y'all have claimed to have fixed and closed, just to
find changes that were not properly applied to see why after I've gone
back to re-build the package it fails to even build, let alone install.

If you don't understand why changes have been made then DO _NOT_ IGNORE
THEM -- ASK _WHY_ THEY'VE BEEN MADE!!!!

If you can't _test_ something fully and _completely_ then either trust
the submitter to have done the test he or she claims to have done, or at
least don't close the friggin PR until someone else can verify the
changes for you!!!!!!

I _have_ tested these changes, _twice_ now, on _both_ platforms which I
originally said I'd tested them on.  They work perfectly for me and
without them the package fails on one or more of those platforms.

Here they are again, as diff's against the most recent module, in case
you can't figure out what I'm talking about:

Index: audio/nas/distinfo
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/audio/nas/distinfo,v
retrieving revision 1.5
diff -c -r1.5 distinfo
*** audio/nas/distinfo	28 Nov 2002 11:40:45 -0000	1.5
--- audio/nas/distinfo	3 Dec 2002 07:50:05 -0000
***************
*** 2,8 ****
  
  SHA1 (nas-1.6.src.tar.gz) = cba0fae4be38cdad9b84e79cbabb8cad2b44bbe0
  Size (nas-1.6.src.tar.gz) = 1099385 bytes
! SHA1 (patch-ab) = f02fba53ac1a3e4debd0401069eba130d670dca7
  SHA1 (patch-ac) = 36f8ee0ec494e9d6a7994780c608c7a5fbf2114d
  SHA1 (patch-ad) = c8e77228282cdd4de5d9686e88a260e286c6bf80
  SHA1 (patch-ae) = f8ec2cb1809937aa7366ab65bee294e8affce543
--- 2,9 ----
  
  SHA1 (nas-1.6.src.tar.gz) = cba0fae4be38cdad9b84e79cbabb8cad2b44bbe0
  Size (nas-1.6.src.tar.gz) = 1099385 bytes
! SHA1 (patch-aa) = 33541c9edd5cc08d9f0b7b6e68ad04f798109155
! SHA1 (patch-ab) = 1e9618b3c9028889a10a026b1d3cf70d61e92de3
  SHA1 (patch-ac) = 36f8ee0ec494e9d6a7994780c608c7a5fbf2114d
  SHA1 (patch-ad) = c8e77228282cdd4de5d9686e88a260e286c6bf80
  SHA1 (patch-ae) = f8ec2cb1809937aa7366ab65bee294e8affce543
cvs diff: Diffing audio/nas/patches
Index: audio/nas/patches/patch-aa
===================================================================
RCS file: audio/nas/patches/patch-aa
diff -N audio/nas/patches/patch-aa
*** /dev/null	1 Jan 1970 00:00:00 -0000
--- audio/nas/patches/patch-aa	3 Dec 2002 00:34:27 -0000
***************
*** 0 ****
--- 1,11 ----
+ --- config/NetAudio.tmpl.orig	Sat Jul 20 21:40:34 2002
+ +++ config/NetAudio.tmpl	Mon Dec  2 19:33:11 2002
+ @@ -158,7 +158,7 @@
+  
+    AUDIODEPLIBS = $(DEPAULIB) $(DEPXTOOLLIB) $(DEPXLIB)
+  #ifndef WIN32
+ -     AUDIOLIBS = $(AULIB) $(XTOOLLIB) $(XLIB) -lm
+ +     AUDIOLIBS = $(AULIB) -lXau -lm
+  #else /* WIN32 */
+       AUDIOLIBS = $(AULIB)
+  #endif /* WIN32 */
Index: audio/nas/patches/patch-ab
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/audio/nas/patches/patch-ab,v
retrieving revision 1.8
diff -c -r1.8 patch-ab
*** audio/nas/patches/patch-ab	28 Nov 2002 11:40:46 -0000	1.8
--- audio/nas/patches/patch-ab	3 Dec 2002 07:49:57 -0000
***************
*** 11,16 ****
--- 11,34 ----
           BSDEMUL = $(LIBSRC)/Berk/Berklib.o
               MFB =
               CFB =
+ @@ -60,7 +60,7 @@
+          SYSLIBS =
+  #endif
+  
+ -#ifdef NetBSDArchitecture
+ +#if defined(NetBSDArchitecture) || defined(__NetBSD__)
+          SYSLIBS = -lossaudio
+  #endif
+  
+ @@ -99,7 +99,7 @@
+  #endif
+  
+  
+ -#if defined(i386SVR4Architecture) || defined(__FreeBSD__) || defined(FreeBSDArchitecture) || defined(LinuxArchitecture) || defined(i386BsdArchitecture) || defined(USLArchitecture) || defined(cygwinArchitecture)
+ +#if defined(i386SVR4Architecture) || defined(__NetBSD__) || defined(NetBSDArchitecture) || defined(__FreeBSD__) || defined(FreeBSDArchitecture) || defined(LinuxArchitecture) || defined(i386BsdArchitecture) || defined(USLArchitecture) || defined(cygwinArchitecture)
+  # define CanBuildAuServer	YES
+  
+  # if defined(LinuxArchitecture)
  @@ -224,6 +224,7 @@
   	$(RM) $(ALL)
   

-- 
								Greg A. Woods

+1 416 218-0098;            <g.a.woods@ieee.org>;           <woods@robohack.ca>
Planix, Inc. <woods@planix.com>; VE3TCP; Secrets of the Weird <woods@weird.com>