Subject: pkg/18814: time to get rid of the 'dd' hack for 'pax'
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 10/26/2002 12:24:26
>Number:         18814
>Category:       pkg
>Synopsis:       time to get rid of the 'dd' hack for 'pax'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 26 09:25:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        pkgsrc-current 2002/10/25
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
	
>Description:

	assuming 1.4.x is deprecated in the eyes of pkgsrc-current then
	it's probably time to undo the 'dd' hack which was used to
	prevent 'pax' from asking for tty input when it encounters
	improperly constructed archives

	('-O' was added to pax well before the netbsd-1-5 branch was created)

>How-To-Repeat:

>Fix:

***************
*** 1645,1651 ****
  # was written with a buggy version of GNU tar.
  #
  .if defined(EXTRACT_USING_PAX)
! _DFLT_EXTRACT_CMD?=	{ ${DECOMPRESS_CMD} $${extract_file} ; dd if=/dev/zero bs=10k count=2; } | ${PAX} -r ${EXTRACT_ELEMENTS}
  .else
  _DFLT_EXTRACT_CMD?=	${DECOMPRESS_CMD} $${extract_file} | ${GTAR} -xf - ${EXTRACT_ELEMENTS}
  .endif
--- 1804,1810 ----
  # was written with a buggy version of GNU tar.
  #
  .if defined(EXTRACT_USING_PAX)
! _DFLT_EXTRACT_CMD?=	${DECOMPRESS_CMD} $${extract_file} | ${PAX} -O -r ${EXTRACT_ELEMENTS}
  .else
  _DFLT_EXTRACT_CMD?=	${DECOMPRESS_CMD} $${extract_file} | ${GTAR} -xf - ${EXTRACT_ELEMENTS}
  .endif
***************
*** 1653,1659 ****
  .for __suffix__ in ${_EXTRACT_SUFFICES}
  .  if !defined(EXTRACT_CMD${__suffix__})
  .    if defined(EXTRACT_USING_PAX)
! EXTRACT_CMD${__suffix__}?=	{ ${DECOMPRESS_CMD${__suffix__}} $${extract_file} ; dd if=/dev/zero bs=10k count=2; } | ${PAX} -r ${EXTRACT_ELEMENTS}
  .  else
  EXTRACT_CMD${__suffix__}?=	${DECOMPRESS_CMD${__suffix__}} $${extract_file} | ${GTAR} -xf - ${EXTRACT_ELEMENTS}
  .    endif
--- 1812,1818 ----
  .for __suffix__ in ${_EXTRACT_SUFFICES}
  .  if !defined(EXTRACT_CMD${__suffix__})
  .    if defined(EXTRACT_USING_PAX)
! EXTRACT_CMD${__suffix__}?=	${DECOMPRESS_CMD${__suffix__}} $${extract_file} | ${PAX} -O -r ${EXTRACT_ELEMENTS}
  .  else
  EXTRACT_CMD${__suffix__}?=	${DECOMPRESS_CMD${__suffix__}} $${extract_file} | ${GTAR} -xf - ${EXTRACT_ELEMENTS}
  .    endif
>Release-Note:
>Audit-Trail:
>Unformatted: