Subject: pkg/18749: www/mozilla/Makefile.common uses both ${SED} and sed
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 10/21/2002 03:01:35
>Number:         18749
>Category:       pkg
>Synopsis:       www/mozilla/Makefile.common uses both ${SED} and sed
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 21 00:02:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        pkgsrc-current 2002/10/19
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD

>Description:

	consistency fixes -- always use ${SED}

>How-To-Repeat:

	by examination

>Fix:

Index: www/mozilla/files/moz-install
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/www/mozilla/files/moz-install,v
retrieving revision 1.3
diff -c -r1.3 moz-install
*** www/mozilla/files/moz-install	19 Oct 2002 15:00:02 -0000	1.3
--- www/mozilla/files/moz-install	21 Oct 2002 06:59:27 -0000
***************
*** 22,52 ****
  
  # install programs
  for i in `${SED} -n -e '/^@comment begin PROGRAMS$/,/^@comment end PROGRAMS$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | sed -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_PROGRAM} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install scripts
  for i in `${SED} -n -e '/^@comment begin SCRIPTS$/,/^@comment end SCRIPTS$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | sed -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_SCRIPT} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install DSO
  for i in `${SED} -n -e '/^@comment begin DSO$/,/^@comment end DSO$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | sed -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_PROGRAM} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install DATA
  for i in `${SED} -n -e '/^@comment begin DATA$/,/^@comment end DATA$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | sed -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_DATA} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install INCLUDE
  for i in `${SED} -n -e '/^@comment begin INCLUDE$/,/^@comment end INCLUDE$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | sed -e "s@include/${MOZILLA}@dist/include@"`;
  	${BSD_INSTALL_DATA} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
--- 22,52 ----
  
  # install programs
  for i in `${SED} -n -e '/^@comment begin PROGRAMS$/,/^@comment end PROGRAMS$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | ${SED} -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_PROGRAM} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install scripts
  for i in `${SED} -n -e '/^@comment begin SCRIPTS$/,/^@comment end SCRIPTS$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | ${SED} -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_SCRIPT} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install DSO
  for i in `${SED} -n -e '/^@comment begin DSO$/,/^@comment end DSO$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | ${SED} -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_PROGRAM} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install DATA
  for i in `${SED} -n -e '/^@comment begin DATA$/,/^@comment end DATA$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | ${SED} -e "s@lib/${MOZILLA}@dist/bin@"`;
  	${BSD_INSTALL_DATA} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
  # install INCLUDE
  for i in `${SED} -n -e '/^@comment begin INCLUDE$/,/^@comment end INCLUDE$/p' ${TMP_PLIST} | ${EGREP} -v ^@comment` ; do
! 	src=`echo $i | ${SED} -e "s@include/${MOZILLA}@dist/include@"`;
  	${BSD_INSTALL_DATA} ${WRKSRC}/${src} ${PREFIX}/$i
  done
  
>Release-Note:
>Audit-Trail:
>Unformatted: