Subject: pkg/18712: net/ORBit doesn't need a run-time dependency on GNU Indent (devel/gindent)
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 10/19/2002 15:10:14
>Number:         18712
>Category:       pkg
>Synopsis:       net/ORBit doesn't need a run-time dependency on GNU Indent (devel/gindent)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 19 12:11:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        pkgsrc-current 2002/10/18
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD

>Description:

	it seems net/ORBit doesn't really need GNU Indent as a run-time
	dependency.  ORBit desires to use some form of 'indent' program
	to pretty-print code its IDL compiler generates.  The default
	options that it wants to use with an 'indent' program are all
	supported by NetBSD's /usr/bin/indent.

	also with the support of security/tcp_wrappers/buildlink2.mk
	it should no longer be necessary to patch the configure script
	either.

	also the AUTOMAKE_OVERRIDE which supposedly causes problems on
	arm32 should be made conditional on being built on arm32 too.

>How-To-Repeat:

	wonder why mozilla needs gindent at run-time....

>Fix:

cvs diff: Diffing net/ORBit
Index: net/ORBit/Makefile
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/net/ORBit/Makefile,v
retrieving revision 1.79
diff -c -r1.79 Makefile
*** net/ORBit/Makefile	27 Sep 2002 00:45:13 -0000	1.79
--- net/ORBit/Makefile	19 Oct 2002 17:51:55 -0000
***************
*** 10,18 ****
  HOMEPAGE=		http://www.gnome.org/
  COMMENT=		high-performance CORBA ORB with support for the C language
  
! DEPENDS+=		gindent-[0-9]*:../../devel/gindent
! 
  AUTOMAKE_OVERRIDE=	NO	# Otherwise breaks 1.5 arm32
  USE_GMAKE=		YES
  USE_LIBTOOL=		YES
  LIBTOOL_OVERRIDE+=	${WRKSRC}/libtool
--- 10,19 ----
  HOMEPAGE=		http://www.gnome.org/
  COMMENT=		high-performance CORBA ORB with support for the C language
  
! .if (${MACHINE_ARCH} == "arm32")
  AUTOMAKE_OVERRIDE=	NO	# Otherwise breaks 1.5 arm32
+ .endif
+ 
  USE_GMAKE=		YES
  USE_LIBTOOL=		YES
  LIBTOOL_OVERRIDE+=	${WRKSRC}/libtool
Index: net/ORBit/distinfo
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/net/ORBit/distinfo,v
retrieving revision 1.13
diff -c -r1.13 distinfo
*** net/ORBit/distinfo	27 Sep 2002 00:45:13 -0000	1.13
--- net/ORBit/distinfo	4 Oct 2002 15:38:48 -0000
***************
*** 4,10 ****
  Size (ORBit-0.5.15.tar.gz) = 1335272 bytes
  SHA1 (patch-aa) = ef745d3d279d57dbdf6380053b6b4a7e63322671
  SHA1 (patch-ab) = c2b7cc5f83230035c214600bff59d4dfefd92422
- SHA1 (patch-ac) = cc073ac41f69671fe10be3975cb0753e163a10dd
  SHA1 (patch-ad) = d4f61e2fef4b862606473ced8f0b27ea3b7f22b3
  SHA1 (patch-ae) = 95cc6f46fa2cfcd34af2e546f3d4a8d55194e5eb
  SHA1 (patch-af) = b88b26b8fe7d42f267c6761edc3e3b8250bd14fb
--- 4,9 ----
cvs diff: Diffing net/ORBit/patches
Index: net/ORBit/patches/patch-ac
===================================================================
RCS file: net/ORBit/patches/patch-ac
diff -N net/ORBit/patches/patch-ac
*** net/ORBit/patches/patch-ac	25 Aug 2002 18:39:31 -0000	1.11
--- /dev/null	1 Jan 1970 00:00:00 -0000
***************
*** 1,15 ****
- $NetBSD: patch-ac,v 1.11 2002/08/25 18:39:31 jlam Exp $
- 
- --- configure.orig	Wed Mar 20 14:45:48 2002
- +++ configure	Thu Apr 25 12:42:56 2002
- @@ -8636,6 +8636,10 @@
-  	THEFILE="`echo $I | sed -e 's,^-L,,'`"
-  	echo "From $I, checking in dir $THEFILE for libwrap.so" 1>&5
-  	if test -f $THEFILE/libwrap.so; then
- +		LIB_WRAP=-lwrap
- +		echo "Found $THEFILE/libwrap.so" 1>&5
- +		break
- +	elif test -f `set $THEFILE/libwrap.so.*.*; echo $1`; then
-  		LIB_WRAP=-lwrap
-  		echo "Found $THEFILE/libwrap.so" 1>&5
-  		break
--- 0 ----
>Release-Note:
>Audit-Trail:
>Unformatted: