Subject: pkg/18656: archivers/gsharutils insufficiently patches PKGLOCALEDIR scenario (patch included)
To: None <gnats-bugs@gnats.netbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: netbsd-bugs
Date: 10/14/2002 16:15:29
>Number:         18656
>Category:       pkg
>Synopsis:       archivers/gsharutils insufficiently patches PKGLOCALEDIR scenario
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 14 07:16:02 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        SunOS 5.9
>Organization:
>Environment:
>Description:

archivers/gsharutils insufficiently patches PKGLOCALEDIR scenario and despite
of patching PKGLOCALEDIR for $(localedir) empty directories are created in the
share/locale (should be lib/locale for SunOS) due to not patched
$(gnulocaledir).

...
making install in po
../mkinstalldirs /usr/pkg/lib
catalogs='de.mo de.gmo fr.mo fr.gmo ja_JP.EUC.mo ja_JP.EUC.gmo nl.mo nl.gmo pt.mo pt.gmo sv.mo sv.gmo';  for cat in $catalogs; do  if test "`echo $cat | sed 's/.*\(\..*\)/\1/'`" = ".gmo"; then  destdir=/usr/pkg/share/locale;  else  destdir=/usr/pkg/lib/locale;  fi;  lang=`echo $cat | sed 's/.mo$//'`;  dir=$destdir/$lang/LC_MESSAGES;  ../mkinstalldirs $dir;  if test -r $cat; then  /usr/ucb/install -c -o root -g sys -m 444 $cat $dir/sharutils.mo;  else  /usr/ucb/install -c -o root -g sys -m 444 ./$cat $dir/sharutils.mo;  fi;  done
mkdir /usr/pkg/share/locale
mkdir /usr/pkg/share/locale/de.
mkdir /usr/pkg/share/locale/de./LC_MESSAGES
mkdir /usr/pkg/share/locale/fr.
mkdir /usr/pkg/share/locale/fr./LC_MESSAGES
mkdir /usr/pkg/share/locale/ja_JP.EUC.
mkdir /usr/pkg/share/locale/ja_JP.EUC./LC_MESSAGES
mkdir /usr/pkg/share/locale/nl.
mkdir /usr/pkg/share/locale/nl./LC_MESSAGES
mkdir /usr/pkg/share/locale/pt.
mkdir /usr/pkg/share/locale/pt./LC_MESSAGES
mkdir /usr/pkg/share/locale/sv.
mkdir /usr/pkg/share/locale/sv./LC_MESSAGES
making install in src
...

also, what's the policy wrt patch-?? files when some of them are removed from
the middle of the alphabet?  there are patch-aa patch-ab patch-ac patch-ad
patch-ae patch-af patch-aj files in patches/.  should the new patch be
patch-ak or patch-ag? shouldn't be patch-aj moved to patch-ag?

>How-To-Repeat:

try to install archivers/gsharutils on Solaris machine

>Fix:

the following patch fixes the problem:

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/gsharutils/distinfo,v
retrieving revision 1.4
diff -u -r1.4 distinfo
--- distinfo	15 Jul 2001 11:44:50 -0000	1.4
+++ distinfo	14 Oct 2002 14:13:43 -0000
@@ -9,3 +9,4 @@
 SHA1 (patch-ae) = 8b88d98af2d1f24ba2623e8d56b36061806f5e12
 SHA1 (patch-af) = 50aee8dc24a33892a0f17f7aeb5cfbae1adcb0c9
 SHA1 (patch-aj) = b7a7f8fba49317f1815e71855d7bf21a0d356af2
+SHA1 (patch-ak) = 2607d7680549440adf7b3f1c3c3a76b7f9b3a818

--- /dev/null	Mon Oct 14 16:02:45 2002
+++ patches/patch-ak	Mon Oct 14 16:09:27 2002
@@ -1,0 +1,13 @@
+$NetBSD$
+
+--- po/Makefile.in.in.orig	Mon Dec  4 17:19:48 1995
++++ po/Makefile.in.in	Mon Oct 14 15:45:56 2002
+@@ -29,7 +29,7 @@
+ exec_prefix = @exec_prefix@
+ datadir = $(prefix)/@DATADIRNAME@
+ localedir = $(datadir)/locale
+-gnulocaledir = $(prefix)/share/locale
++gnulocaledir = $(datadir)/locale
+ gettextsrcdir = $(prefix)/share/gettext
+ subdir = po
+ 
>Release-Note:
>Audit-Trail:
>Unformatted: