Subject: pkg/18622: devel/ncurses incorrectly installs terminfo files to wrong place on Solaris
To: None <gnats-bugs@gnats.netbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: netbsd-bugs
Date: 10/11/2002 20:12:02
>Number:         18622
>Category:       pkg
>Synopsis:       devel/ncurses installs terminfo files to wrong place on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 11 11:13:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        NetBSD 1.6
>Organization:
>Environment:
>Description:

devel/ncurses tries to handle screen terminfo entries differently on solaris
but it never changes the default installation path which is
${PREFIX}/share/terminfo for all terminfo entries while PLIST expects them in
${PREFIX}/share/lib/terminfo and thus ends in corrupted installation.

this patch fixes this problem and changes the conditional written by tron a
bit.  it would be cleaner to use two PLIST files and include the one
containing only screen terminfo entries when not on Solaris but it seems that
tron didn't want to add another file and rather worked this around directly in
Makefile so i kept it this way.

>How-To-Repeat:

try to build devel/ncurses on Solaris

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/ncurses/Makefile,v
retrieving revision 1.40
diff -u -r1.40 Makefile
--- Makefile	2002/09/01 18:36:35	1.40
+++ Makefile	2002/10/11 18:01:59
@@ -27,12 +27,18 @@
 .include "../../mk/bsd.prefs.mk"
 
 .if (${OPSYS} == SunOS)
-PLIST_SUBST+=	NOT_SUNOS="@comment " TERMINFODIR=share/lib/terminfo
-
+PLIST_SUBST+=	NOT_SUNOS="@comment "
 TERMINFO_SRC=	${WRKSRC}/misc/terminfo.src
+TERMINFODIR=	share/lib/terminfo
 .else
-PLIST_SUBST+=	NOT_SUNOS= TERMINFODIR=share/terminfo
+PLIST_SUBST+=	NOT_SUNOS=""
+TERMINFODIR=	share/terminfo
 .endif
+
+PLIST_SUBST+=	TERMINFODIR="${TERMINFODIR}"
+
+CONFIGURE_ARGS+=	--with-default-terminfo-dir=${PREFIX}/${TERMINFODIR}
+CONFIGURE_ARGS+=	--with-terminfo-dirs=${PREFIX}/${TERMINFODIR}
 
 # Remove these manpages from the distribution so they won't get installed
 CURSES_NO_MAN=		clear.1 tput.1 tset.1
>Release-Note:
>Audit-Trail:
>Unformatted: