Subject: pkg/18362: buildlink2.mk of audio/arts requires bsd.prefs.mk
To: None <gnats-bugs@gnats.netbsd.org>
From: Julio Merino <jmmv@hispabsd.org>
List: netbsd-bugs
Date: 09/21/2002 16:19:11
>Number:         18362
>Category:       pkg
>Synopsis:       buildlink2.mk of audio/arts requires bsd.prefs.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 21 07:19:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Julio Merino
>Release:        NetBSD 1.6H
>Organization:
HispaBSD
>Environment:
	
	
System: NetBSD darkstar.local 1.6H NetBSD 1.6H (DARKSTAR) #16: Fri Sep 20 11:10:50 CEST 2002 jmmv@darkstar.local:/var/build/kernel/DARKSTAR i386
Architecture: i386
Machine: i386
>Description:
	The buildlink2.mk file of audio/arts uses the variable ${GREP}
	which, depending on the package beeing built, may be defined or not.
	If it is not defined, weird things happen.

	In order to get this working properly, the buildlink2.mk file
	must include bsd.prefs.mk before using the variable. If not, the
	package maintainer who wants to use this buildlink2.mk file has to
	do this inclusion; this behavior is not wanted, though.
>How-To-Repeat:
	Create a package that includes the audio/arts/buildlink2.mk file,
	without including bsd.prefs.mk by hand. When issuing `make', you
	get the following:

^\(include\|lib\): not found
make: "/mass/sources/pkgsrc/misc/navigatrix/../../audio/arts/buildlink2.mk" line 12: warning: " "^\(include\|lib\)" /mass/sources/pkgsrc/misc/navigatrix/../../audio/arts/PLIST" returned non-zero status
>Fix:
	This small fix should solve the problem:

Index: buildlink2.mk
===================================================================
RCS file: /cvsroot/pkgsrc/audio/arts/buildlink2.mk,v
retrieving revision 1.2
diff -u -u -r1.2 buildlink2.mk
--- buildlink2.mk	2002/08/25 19:21:43	1.2
+++ buildlink2.mk	2002/09/21 14:14:02
@@ -7,6 +7,8 @@
 BUILDLINK_DEPENDS.arts?=	arts>=1.0.0
 BUILDLINK_PKGSRCDIR.arts?=	../../audio/arts
 
+.include "../../mk/bsd.prefs.mk"
+
 EVAL_PREFIX+=			BUILDLINK_PREFIX.arts=arts
 BUILDLINK_PREFIX.arts_DEFAULT=	${X11PREFIX}
 BUILDLINK_FILES.arts!=	${GREP} "^\(include\|lib\)" ${.CURDIR}/../../audio/arts/PLIST



>Release-Note:
>Audit-Trail:
>Unformatted: