Subject: pkg/18095: Makefile bug in www/ap-dav
To: None <gnats-bugs@gnats.netbsd.org>
From: None <julien.letessier@sun.com>
List: netbsd-bugs
Date: 08/28/2002 00:30:16
>Number:         18095
>Category:       pkg
>Synopsis:       Makefile bug in www/ap-dav
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 28 00:31:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Julien T. Letessier
>Release:        Zoularis/Solaris8
>Organization:
Sun Labs Europe
>Environment:
SunOS mikdemia 5.8 Generic_108528-15 sun4u sparc SUNW,Ultra-Enterprise
>Description:
The 4.4BSD install script (the one in /usr/ucb/install under Solaris) can only install one directory at a time, so ${INSTALL_DATA_DIR} can only have one argument (in its current form).

This has to be corrected in many other packages, I just wanted to point out the problem here; I'll PR later for other packages.
>How-To-Repeat:
Install www/ap-dav on Solaris.
>Fix:
Simple solution: break lines (diff below). 
Hard solution: turn ${INSTALL_DATA_DIR} into something that can take more than 1 arguments...

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/ap-dav/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	2002/08/13 22:19:48	1.5
+++ Makefile	2002/08/28 07:05:21
@@ -24,7 +24,8 @@
 
 do-install:
 	${INSTALL_DATA} ${WRKSRC}/libdav.so ${AP_MODULE_DIR}/mod_dav.so
-	${INSTALL_DATA_DIR} ${DOCDIR} ${HTMLDIR}
+	${INSTALL_DATA_DIR} ${HTMLDIR}
+	${INSTALL_DATA_DIR} ${DOCDIR}
 	${INSTALL_DATA} ${WRKSRC}/INSTALL ${DOCDIR}
 	${INSTALL_DATA} ${WRKSRC}/README ${DOCDIR}
 	${INSTALL_DATA} ${WRKSRC}/LICENSE.html ${HTMLDIR}

>Release-Note:
>Audit-Trail:
>Unformatted: