Subject: bin/17718: sushi crashes in usermgmt.conf editor, does not backup config files, other random problems
To: None <gnats-bugs@gnats.netbsd.org>
From: None <grant@netbsd.org>
List: netbsd-bugs
Date: 07/25/2002 19:19:27
>Number:         17718
>Category:       bin
>Synopsis:       sushi crashes in usermgmt.conf editor, does not backup config files, other random problems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 25 02:20:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     grant beattie
>Release:        NetBSD 1.6_BETA4, 20020630 source
>Organization:
>Environment:
System: NetBSD redback 1.6_BETA4 NetBSD 1.6_BETA4 (GENERIC) #0: Mon Jul 1 10:08:07 EST 2002 grant@mofo:/work/netbsd/netbsd-1-6/20020630/sparc/obj/sys/arch/sparc/compile/GENERIC sparc
Architecture: sparc
Machine: sparc
>Description:
sushi has various serious problems.

it bombs when using the usermgmt.conf editor:

expr: syntax error
sushi: fgetln: No such file or directory

 16868 sushi    GIO   fd 1 wrote 21 bytes
       "
        
        
        \^[[?1l\^[>\^[[34h\^[[?25h"
 16868 sushi    RET   write 21/0x15
 16868 sushi    CALL  __fstat13(0x1,0xefffe758)
 16868 sushi    RET   __fstat13 0
 16868 sushi    CALL  ioctl(0,TIOCSETAW,0xefffe800)
 16868 sushi    RET   ioctl 0
 16868 sushi    CALL  write(0x2,0xefffdf60,0x7)
 16868 sushi    GIO   fd 2 wrote 7 bytes
       "sushi: "
 16868 sushi    RET   write 7
 16868 sushi    CALL  write(0x2,0xefffdfc8,0x21)
 16868 sushi    GIO   fd 2 wrote 33 bytes
       "fgetln: No such file or directory"
 16868 sushi    RET   write 33/0x21
 16868 sushi    CALL  write(0x2,0xefffdf60,0x1)
 16868 sushi    GIO   fd 2 wrote 1 bytes
       "
       "
 16868 sushi    RET   write 1
 16868 sushi    CALL  exit(0x1)

using the startup config editor resulted in a trashed rc.conf, with no
overwrite confirmation or backup copy made.

Subsequent attempts to edit startup config result in:

core dumped. your fault! (signal 11)
Abort (core dumped)

I do not currently have a debug version to play around with.

screen redraws are a little buggy, when scrolling over the menu items,
some menu lines are flashed briefly before being overwritten with blanks.

obviously, this is far from an exhaustive list of problems.

>How-To-Repeat:
run sushi, attempt to use usermgmt.conf editor or startup config editor
to do anything useful, watch the sparks fly.

>Fix:
The user should at least have a chance to confirm changes to config files,
and they should be backed up before changes are made.

/etc/rc.conf should not be rewritten with variables which have not
changed, ie. those that are taken straight from /etc/defaults/rc.conf.
the settings I had in /etc/rc.conf are now gone - this should not
happen.

As for the random crashes, unknown.

It is obvious that sushi is not robust or had enough testing at the
moment. imho, we should reconsider shipping it with the 1.6 release.

>Release-Note:
>Audit-Trail:
>Unformatted: