>Number:         17500
>Category:       pkg
>Synopsis:       converters/libiconv is redundant for Solaris and Linux (it' part of libc)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 06 21:03:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        SunOS 5.9
>Organization:
>Environment:
>Description:

iconv() is a part of libc in Solaris (checked 2.6, 7, 8 and 9) and GNU/Linux.

>How-To-Repeat:

remove PLIST.SunOS and apply following patch

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/converters/libiconv/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- Makefile	14 May 2002 15:57:55 -0000	1.9
+++ Makefile	7 Jul 2002 03:53:37 -0000
@@ -10,18 +10,14 @@
 HOMEPAGE=		http://www.gnu.org/software/libiconv/
 COMMENT=		character set conversion library
 
+NOT_FOR_PLATFORM=	SunOS-*-* Linux-*-*
+
 USE_BUILDLINK_ONLY=	YES
 GNU_CONFIGURE=		YES
 USE_GMAKE=		YES
 USE_LIBTOOL=		YES
 LIBTOOL_OVERRIDE+=	${WRKSRC}/libtool
 LIBTOOL_OVERRIDE+=	${WRKSRC}/libcharset/libtool
-
-.include "../../mk/bsd.prefs.mk"
-
-.if (${OPSYS} == SunOS)
-PLIST_SRC=		${PKGDIR}/PLIST.${OPSYS}
-.endif
 
 # remove any existing charset.alias; if it already exists, libiconv does
 # not overwrite it, and older versions of libiconv wrote incorrect
Index: buildlink.mk
===================================================================
RCS file: /cvsroot/pkgsrc/converters/libiconv/buildlink.mk,v
retrieving revision 1.10
diff -u -r1.10 buildlink.mk
--- buildlink.mk	14 May 2002 15:57:55 -0000	1.10
+++ buildlink.mk	7 Jul 2002 03:53:37 -0000
@@ -16,7 +16,14 @@
 ICONV_BUILDLINK_MK=	# defined
 
 .include "../../mk/bsd.buildlink.mk"
+.include "../../mk/bsd.prefs.mk"
 
+_NEED_LIBICONV=		YES
+.if (${OPSYS} == SunOS) || (${OPSYS} == Linux)
+_NEED_LIBICONV=		NO
+.endif
+
+.if ${_NEED_LIBICONV} == "YES"
 BUILDLINK_DEPENDS.iconv?=	libiconv>=1.7nb2
 DEPENDS+=	${BUILDLINK_DEPENDS.iconv}:../../converters/libiconv
 
@@ -32,5 +39,6 @@
 
 pre-configure: ${BUILDLINK_TARGETS.iconv}
 iconv-buildlink: _BUILDLINK_USE
+.endif  # _NEED_LIBICONV
 
 .endif	# ICONV_BUILDLINK_MK
>Release-Note:
>Audit-Trail:
>Unformatted: