Subject: kern/17389: failed ipv4 software computed checksums are not counted?
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 06/25/2002 13:54:31
>Number: 17389
>Category: kern
>Synopsis: failed ipv4 software computed checksums are not counted?
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Jun 25 11:54:08 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Greg A. Woods
>Release: NetBSD-current 2002/06/23
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:
It seems failed ipv4 software computed checksums are not counted...
>How-To-Repeat:
>Fix:
Index: ip_input.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/syssrc/sys/netinet/ip_input.c,v
retrieving revision 1.150.4.1
diff -c -c -r1.150.4.1 ip_input.c
*** ip_input.c 7 Jun 2002 19:39:21 -0000 1.150.4.1
--- ip_input.c 25 Jun 2002 17:51:50 -0000
***************
*** 477,483 ****
/* Must compute it ourselves. */
INET_CSUM_COUNTER_INCR(&ip_swcsum);
if (in_cksum(m, hlen) != 0)
! goto bad;
break;
}
--- 477,483 ----
/* Must compute it ourselves. */
INET_CSUM_COUNTER_INCR(&ip_swcsum);
if (in_cksum(m, hlen) != 0)
! goto badcsum;
break;
}
***************
*** 808,813 ****
--- 808,814 ----
badcsum:
ipstat.ips_badsum++;
m_freem(m);
+ return;
}
/*
>Release-Note:
>Audit-Trail:
>Unformatted: