Subject: port-next68k/16928: scsi driver (esp) doesn't attach anymore
To: None <gnats-bugs@gnats.netbsd.org>
From: None <chris@Pin.LU>
List: netbsd-bugs
Date: 05/20/2002 17:47:02
>Number:         16928
>Category:       port-next68k
>Synopsis:       scsi driver (esp) doesn't attach anymore
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-next68k-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 20 09:27:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Christian Limpach
>Release:        current (as of May 20 2002)
>Organization:
	
>Environment:
	
System: NetBSD clapper 1.5ZC NetBSD 1.5ZC (CLAPPER) #46: Mon May 13 20:51:50 CEST 2002     root@marble:/devel/netbsd/src-current/sys/arch/next68k/compile/CLAPPER next68k
arch/next68k/dev/esp.c rev. 1.35


>Description:
	crash during scsibus scan:
	scsibus0: waiting 2 seconds for devices to settle...
	trap: bad kernel read access at 0x0
	trap type 8, code = 0x5e6, v = 0x0
	kernel program counter = 0x0

>How-To-Repeat:
	build/boot kernel with the esp driver enabled

>Fix:
	The code attaching the ncr53c9x wasn't updated after thorpej_scsipi
	was merged.  The esp driver has to set adapt_request and adapt_minphys.
	Not setting adapt_request causes the jump to 0x0.

Index: esp.c
===================================================================
RCS file: /cvsroot/syssrc/sys/arch/next68k/dev/esp.c,v
retrieving revision 1.35
diff -u -r1.35 esp.c
--- esp.c	2001/05/23 02:14:07	1.35
+++ esp.c	2002/05/20 16:14:27
@@ -396,6 +396,8 @@
 	    sc->sc_dev.dv_xname, "intr");
 
 	/* Do the common parts of attachment. */
+	sc->sc_adapter.adapt_minphys = minphys;
+	sc->sc_adapter.adapt_request = ncr53c9x_scsipi_request;
 	ncr53c9x_attach(sc);
 }
 
>Release-Note:
>Audit-Trail:
>Unformatted: