Subject: Re: xsrc/16072: Enable XFree86 aperture driver support by default on i386
To: None <netbsd-bugs@netbsd.org>
From: Geoff Wing <gcw@pobox.com>
List: netbsd-bugs
Date: 03/28/2002 14:03:33
Stephen Ma <stephenm@employees.org> typed:
:--- /v1/netbsd/xsrc/xfree/xc/config/cf/NetBSD.cf	Sun Jan 20 11:38:38 2002
:+++ ./NetBSD.cf	Tue Mar 26 14:15:05 2002
:@@ -346,5 +346,5 @@
: #if defined(i386Architecture)
: # ifndef HasNetBSDApertureDriver
:-#  define HasNetBSDApertureDriver	NO
:+#  define HasNetBSDApertureDriver	YES
:    /* Where the aperture driver is installed */
: #  ifndef NetBSDApertureDir

This doesn't make sense.  Surely this means you must have already
installed apNetBSD.shar (or the pkgsrc sysutils/aperture) otherwise
bsd_video.c(*) will bomb out - it won't find "memrange.h" which comes
with the aperture package.
 (*) = xfree/xc/programs/Xserver/hw/xfree86/os-support/bsd/bsd_video.c

Even more importantly is this, a couple of lines down from the patch:
 #   define NetBSDApertureDir            /usr/local/aperture

NetBSDApertureDir/include is where it's going to look for "memrange.h"

This is only the case if they've preinstalled apNetBSD.shar using the
default instructions, in which case they've probably edited the cf and
rebuilt.  If they've preinstalled sysutils/aperture then it's now /usr/pkg
and the build of bsd_video.c will again bomb out.

The only way to allow HasNetBSDApertureDriver to be set also means that
the aperture driver _must_ be prebuilt, installed and available.  Because
there's also no fallback mechanism to /dev/mem if /dev/xf86 is not available.

Regards,
-- 
Geoff Wing : <gcw@pobox.com>
Rxvt Stuff : <gcw@rxvt.org>
Zsh Stuff  : <gcw@zsh.org>